Skip to content

GitLab

Commit 4b4834e5 authored by Brian Tiger Chow's avatar Brian Tiger Chow
Browse files
Options

refac(bitswap) nil slices are 'range'able

parent 554b5a49
Show whitespace changes
Inline Side-by-side
Showing with 18 additions and 22 deletions
bitswap.go
View file @ 4b4834e5
...@@ -117,7 +117,6 @@ func (bs *bitswap) ReceiveMessage( ...@@ -117,7 +117,6 @@ func (bs *bitswap) ReceiveMessage(
bs.strategy.MessageReceived(p, incoming) bs.strategy.MessageReceived(p, incoming)
if incoming.Blocks() != nil {
for _, block := range incoming.Blocks() { for _, block := range incoming.Blocks() {
err := bs.blockstore.Put(block) // FIXME(brian): err ignored err := bs.blockstore.Put(block) // FIXME(brian): err ignored
if err != nil { if err != nil {
...@@ -129,9 +128,7 @@ func (bs *bitswap) ReceiveMessage( ...@@ -129,9 +128,7 @@ func (bs *bitswap) ReceiveMessage(
return nil, nil, err return nil, nil, err
} }
} }
}
if incoming.Wantlist() != nil {
for _, key := range incoming.Wantlist() { for _, key := range incoming.Wantlist() {
if bs.strategy.ShouldSendBlockToPeer(key, p) { if bs.strategy.ShouldSendBlockToPeer(key, p) {
block, errBlockNotFound := bs.blockstore.Get(key) block, errBlockNotFound := bs.blockstore.Get(key)
...@@ -144,7 +141,6 @@ func (bs *bitswap) ReceiveMessage( ...@@ -144,7 +141,6 @@ func (bs *bitswap) ReceiveMessage(
return p, message, nil return p, message, nil
} }
} }
}
return nil, nil, nil return nil, nil, nil
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment