fix: possible deadlock scenario in session want sender (#271)

a44198e3 · dirkmc · GitHub · d7c2ca39 · a44198e3
Unverified Commit a44198e3 authored Feb 27, 2020 by dirkmc Committed by GitHub Feb 27, 2020
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

internal/session/sessionwantsender.go internal/session/sessionwantsender.go +6 -2

No files found.
--- a/internal/session/sessionwantsender.go
+++ b/internal/session/sessionwantsender.go
@@ -366,9 +366,13 @@ func (spm *sessionWantSender) processUpdates(updates []update) {

 	// If any peers have sent us too many consecutive DONT_HAVEs, remove them
 	// from the session
+	if len(prunePeers) > 0 {
+		go func() {
 			for p := range prunePeers {
 				spm.SignalAvailability(p, false)
 			}
+		}()
+	}
 }

 // convenience structs for passing around want-blocks and want-haves for a peer