add warning comment about possibly leaked goroutines

bb99f55b · Jeromy · 8de772f4 · bb99f55b
Commit bb99f55b authored Mar 09, 2015 by Jeromy
Show whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

bitswap.go bitswap.go +6 -0

No files found.
--- a/bitswap.go
+++ b/bitswap.go
@@ -260,6 +260,9 @@ loop:
 	select {
 	case <-done:
 	case <-ctx.Done():
+		// NB: we may be abandoning goroutines here before they complete
+		// this shouldnt be an issue because they will complete soon anyways
+		// we just don't want their being slow to impact bitswap transfer speeds
 	}
 	return nil
 }
@@ -412,6 +415,9 @@ func (bs *Bitswap) wantNewBlocks(ctx context.Context, bkeys []u.Key) {
 	select {
 	case <-done:
 	case <-ctx.Done():
+		// NB: we may be abandoning goroutines here before they complete
+		// this shouldnt be an issue because they will complete soon anyways
+		// we just don't want their being slow to impact bitswap transfer speeds
 	}
 }