From e6c5fc250c8de0563b32b9832964f0cbfce796bc Mon Sep 17 00:00:00 2001
From: Brian Tiger Chow <brian.holderchow@gmail.com>
Date: Wed, 12 Nov 2014 23:53:49 -0800
Subject: [PATCH] docs(commands) todo
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
---
commands/cli/parse.go | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/commands/cli/parse.go b/commands/cli/parse.go
index 803d19d79..b84ecca76 100644
--- a/commands/cli/parse.go
+++ b/commands/cli/parse.go
@@ -160,7 +160,10 @@ func argValue(argDef cmds.Argument, value string) (interface{}, error) {
return value, nil
} else {
- in, err := os.Open(value) // FIXME(btc) must close file. fix before merge
+ // NB At the time of this commit, file cleanup is performed when
+ // Requests are cleaned up. TODO try to perform open and close at the
+ // same level of abstraction (or at least in the same package!)
+ in, err := os.Open(value)
if err != nil {
return nil, err
}
--
GitLab