From fed5f05134b70a9e51a4c13498dd2708111a4bc1 Mon Sep 17 00:00:00 2001
From: Steven Allen <steven@stebalien.com>
Date: Mon, 8 Feb 2021 12:41:35 -0800
Subject: [PATCH] build: simplify on gofmt

---
 assets/assets.go          |  4 ++--
 bin/test-go-fmt           |  2 +-
 test/bin/verify-go-fmt.sh | 19 -------------------
 3 files changed, 3 insertions(+), 22 deletions(-)
 delete mode 100755 test/bin/verify-go-fmt.sh

diff --git a/assets/assets.go b/assets/assets.go
index 920488f4f..d203089f8 100644
--- a/assets/assets.go
+++ b/assets/assets.go
@@ -1,8 +1,8 @@
 //go:generate git submodule update --init ./dir-index-html
 //go:generate go run github.com/go-bindata/go-bindata/v3/go-bindata -mode=0644 -modtime=1403768328 -pkg=assets init-doc dir-index-html/dir-index.html dir-index-html/knownIcons.txt
-//go:generate gofmt -w bindata.go
+//go:generate gofmt -sw bindata.go
 //go:generate sh -c "sed -i \"s/.*BindataVersionHash.*/BindataVersionHash=\\\"$(git hash-object bindata.go)\\\"/\" bindata_version_hash.go"
-//go:generate gofmt -w bindata_version_hash.go
+//go:generate gofmt -sw bindata_version_hash.go
 package assets
 
 import (
diff --git a/bin/test-go-fmt b/bin/test-go-fmt
index a9e6d5a73..8bd1f07bf 100755
--- a/bin/test-go-fmt
+++ b/bin/test-go-fmt
@@ -4,7 +4,7 @@ T="$(mktemp)"
 find . \
     -path ./test/sharness -prune \
  -o -path ./plugin/loader/preload.go -prune \
- -o -name '*.go' -print0 | xargs -0 gofmt -l > "$T"
+ -o -name '*.go' -print0 | xargs -0 gofmt -sl > "$T"
 
 if [ -n "$(cat $T)" ]; then
 	echo "Following Go code is not formatted."
diff --git a/test/bin/verify-go-fmt.sh b/test/bin/verify-go-fmt.sh
deleted file mode 100755
index fedcf511a..000000000
--- a/test/bin/verify-go-fmt.sh
+++ /dev/null
@@ -1,19 +0,0 @@
-#!/bin/sh
-
-#TODO add go lint and go vet
-
-verify_gofmt() {
-    GOFMT="gofmt -s"
-    cd "$(git rev-parse --show-toplevel)"
-    bad_files=$($GOFMT -l .)
-    cd -
-    if [[ -n $bad_files ]]; then
-        echo "You have to run '$GOFMT' on these files:"
-        echo "$bad_files"
-        false
-    else
-        true
-    fi
-}
-
-verify_gofmt
-- 
GitLab