Remove temp file on error in writeDiskUsageFile.

ab36d364 · Kevin Atkinson · 24e5fbe6 · ab36d364
Commit ab36d364 authored Apr 02, 2018 by Kevin Atkinson
Show whitespace changes
Inline Side-by-side

Showing with 8 additions and 0 deletions

flatfs.go flatfs.go +8 -0

No files found.
--- a/flatfs.go
+++ b/flatfs.go
@@ -868,6 +868,13 @@ func (fs *Datastore) checkpointLoop() {

 func (fs *Datastore) writeDiskUsageFile(du int64, doSync bool) {
 	tmp, err := ioutil.TempFile(fs.path, "du-")
+	removed := false
+	defer func() {
+		if !removed {
+			// silence errcheck
+			_ = os.Remove(tmp.Name())
+		}
+	}()
 	if err != nil {
 		log.Warningf("cound not write disk usage: %v", err)
 		return
@@ -897,6 +904,7 @@ func (fs *Datastore) writeDiskUsageFile(du int64, doSync bool) {
 		log.Warningf("cound not write disk usage: %v", err)
 		return
 	}
+	removed = true

 	fs.storedValue = toWrite
 	fs.dirty = false