Skip to content

GitLab

Commit ab36d364 authored by Kevin Atkinson's avatar Kevin Atkinson
Browse files
Options

Remove temp file on error in writeDiskUsageFile.

parent 24e5fbe6
Show whitespace changes
Inline Side-by-side
Showing with 8 additions and 0 deletions
flatfs.go
View file @ ab36d364
...@@ -868,6 +868,13 @@ func (fs *Datastore) checkpointLoop() { ...@@ -868,6 +868,13 @@ func (fs *Datastore) checkpointLoop() {
func (fs *Datastore) writeDiskUsageFile(du int64, doSync bool) { func (fs *Datastore) writeDiskUsageFile(du int64, doSync bool) {
tmp, err := ioutil.TempFile(fs.path, "du-") tmp, err := ioutil.TempFile(fs.path, "du-")
removed := false
defer func() {
if !removed {
// silence errcheck
_ = os.Remove(tmp.Name())
}
}()
if err != nil { if err != nil {
log.Warningf("cound not write disk usage: %v", err) log.Warningf("cound not write disk usage: %v", err)
return return
...@@ -897,6 +904,7 @@ func (fs *Datastore) writeDiskUsageFile(du int64, doSync bool) { ...@@ -897,6 +904,7 @@ func (fs *Datastore) writeDiskUsageFile(du int64, doSync bool) {
log.Warningf("cound not write disk usage: %v", err) log.Warningf("cound not write disk usage: %v", err)
return return
} }
removed = true
fs.storedValue = toWrite fs.storedValue = toWrite
fs.dirty = false fs.dirty = false
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment