Commit 1bcb27fd authored by Hector Sanjuan's avatar Hector Sanjuan

merkledag_test: address #4704 review comments

License: MIT
Signed-off-by: default avatarHector Sanjuan <hector@protocol.ai>
parent 0a8f8e30
...@@ -134,7 +134,7 @@ func makeTestDAG(t *testing.T, read io.Reader, ds ipld.DAGService) ipld.Node { ...@@ -134,7 +134,7 @@ func makeTestDAG(t *testing.T, read io.Reader, ds ipld.DAGService) ipld.Node {
p := make([]byte, 512) p := make([]byte, 512)
nodes := []*ProtoNode{} nodes := []*ProtoNode{}
var err error var err error
_, err = read.Read(p) _, err = io.ReadFull(read, p)
for err == nil { for err == nil {
protoNode := NodeWithData(p) protoNode := NodeWithData(p)
nodes = append(nodes, protoNode) nodes = append(nodes, protoNode)
...@@ -225,8 +225,6 @@ func runBatchFetchTest(t *testing.T, read io.Reader) { ...@@ -225,8 +225,6 @@ func runBatchFetchTest(t *testing.T, read io.Reader) {
if !ok { if !ok {
errs <- ErrNotProtobuf errs <- ErrNotProtobuf
} }
_ = firstpb
_ = expected
read := makeTestDAGReader(t, firstpb, dagservs[i]) read := makeTestDAGReader(t, firstpb, dagservs[i])
datagot, err := ioutil.ReadAll(read) datagot, err := ioutil.ReadAll(read)
if err != nil { if err != nil {
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment