Commit d54bc701 authored by Juan Batiz-Benet's avatar Juan Batiz-Benet

added cancel func calls previously ignored

parent 7e655ddf
...@@ -88,7 +88,8 @@ func (n *dagService) Get(k u.Key) (*Node, error) { ...@@ -88,7 +88,8 @@ func (n *dagService) Get(k u.Key) (*Node, error) {
return nil, fmt.Errorf("dagService is nil") return nil, fmt.Errorf("dagService is nil")
} }
ctx, _ := context.WithTimeout(context.TODO(), time.Minute) ctx, cancel := context.WithTimeout(context.TODO(), time.Minute)
defer cancel()
// we shouldn't use an arbitrary timeout here. // we shouldn't use an arbitrary timeout here.
// since Get doesnt take in a context yet, we give a large upper bound. // since Get doesnt take in a context yet, we give a large upper bound.
// think of an http request. we want it to go on as long as the client requests it. // think of an http request. we want it to go on as long as the client requests it.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment