From ffcc4b77dd181ed7b2179e7e4013b70461473b22 Mon Sep 17 00:00:00 2001
From: "Masih H. Derkani" <m@derkani.org>
Date: Wed, 21 Jul 2021 10:21:40 +0100
Subject: [PATCH] Improve error handing in tests

When error is not expected in tests, assert that there is indeed no
error.
---
 v2/index/index_test.go |  1 +
 v2/index_gen_test.go   | 12 ++++++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/v2/index/index_test.go b/v2/index/index_test.go
index 03efbc9..acafffe 100644
--- a/v2/index/index_test.go
+++ b/v2/index/index_test.go
@@ -39,6 +39,7 @@ func TestNew(t *testing.T) {
 			if tt.wantErr {
 				require.Error(t, err)
 			} else {
+				require.NoError(t, err)
 				require.Equal(t, tt.want, got)
 			}
 		})
diff --git a/v2/index_gen_test.go b/v2/index_gen_test.go
index 97eb244..058d07e 100644
--- a/v2/index_gen_test.go
+++ b/v2/index_gen_test.go
@@ -98,9 +98,11 @@ func TestReadOrGenerateIndex(t *testing.T) {
 			got, err := ReadOrGenerateIndex(carFile, tt.readOpts...)
 			if tt.wantErr {
 				require.Error(t, err)
+			} else {
+				require.NoError(t, err)
+				want := tt.wantIndexer(t)
+				require.Equal(t, want, got)
 			}
-			want := tt.wantIndexer(t)
-			require.Equal(t, want, got)
 		})
 	}
 }
@@ -143,9 +145,11 @@ func TestGenerateIndexFromFile(t *testing.T) {
 			got, err := GenerateIndexFromFile(tt.carPath)
 			if tt.wantErr {
 				require.Error(t, err)
+			} else {
+				require.NoError(t, err)
+				want := tt.wantIndexer(t)
+				require.Equal(t, want, got)
 			}
-			want := tt.wantIndexer(t)
-			require.Equal(t, want, got)
 		})
 	}
 }
-- 
GitLab