From deedd3bb82c7ade24baf4b6542f4f16c2074c4ec Mon Sep 17 00:00:00 2001
From: Steven Allen <steven@stebalien.com>
Date: Sun, 21 Jan 2018 10:57:30 -0800
Subject: [PATCH] support large slices

They won't use the buffer pool but it doesn't hurt to be nice to the user by
allocating such slices anyways.
---
 pool.go      | 13 ++++++++-----
 pool_test.go | 14 +++++++-------
 2 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/pool.go b/pool.go
index 6a03299..6e7a8c8 100644
--- a/pool.go
+++ b/pool.go
@@ -48,15 +48,18 @@ type BufferPool struct {
 // values returned by Get.
 //
 // If no suitable buffer exists in the pool, Get creates one.
-func (p *BufferPool) Get(length uint32) []byte {
+func (p *BufferPool) Get(length int) []byte {
 	if length == 0 {
 		return nil
 	}
-	idx := nextLogBase2(length)
+	if length > MaxLength {
+		return make([]byte, length)
+	}
+	idx := nextLogBase2(uint32(length))
 	if buf := p.pools[idx].Get(); buf != nil {
-		return buf.([]byte)[:length]
+		return buf.([]byte)[:uint32(length)]
 	}
-	return make([]byte, 1<<idx)[:length]
+	return make([]byte, 1<<idx)[:uint32(length)]
 }
 
 // Put adds x to the pool.
@@ -71,7 +74,7 @@ func (p *BufferPool) Put(buf []byte) {
 
 // Get retrieves a buffer of the appropriate length from the global buffer pool
 // (or allocates a new one).
-func Get(length uint32) []byte {
+func Get(length int) []byte {
 	return GlobalPool.Get(length)
 }
 
diff --git a/pool_test.go b/pool_test.go
index be45ca6..e3d7d14 100644
--- a/pool_test.go
+++ b/pool_test.go
@@ -65,7 +65,7 @@ func TestPoolStressByteSlicePool(t *testing.T) {
 
 	const P = 10
 	chs := 10
-	maxSize := uint32(1 << 16)
+	maxSize := 1 << 16
 	N := int(1e4)
 	if testing.Short() {
 		N /= 100
@@ -77,18 +77,18 @@ func TestPoolStressByteSlicePool(t *testing.T) {
 			ch := make(chan []byte, chs+1)
 
 			for i := 0; i < chs; i++ {
-				j := rand.Uint32() % maxSize
+				j := rand.Int() % maxSize
 				ch <- p.Get(j)
 			}
 
 			for j := 0; j < N; j++ {
-				r := uint32(0)
+				r := 0
 				for i := 0; i < chs; i++ {
 					v := <-ch
 					p.Put(v)
-					r = rand.Uint32() % maxSize
+					r = rand.Int() % maxSize
 					v = p.Get(r)
-					if uint32(len(v)) < r {
+					if len(v) < r {
 						errs <- fmt.Errorf("expect len(v) >= %d, got %d", j, len(v))
 					}
 					ch <- v
@@ -115,7 +115,7 @@ func TestPoolStressByteSlicePool(t *testing.T) {
 func BenchmarkPool(b *testing.B) {
 	var p BufferPool
 	b.RunParallel(func(pb *testing.PB) {
-		i := uint32(7)
+		i := 7
 		for pb.Next() {
 			if i > 1<<20 {
 				i = 7
@@ -135,7 +135,7 @@ func BenchmarkPoolOverlflow(b *testing.B) {
 			bufs := make([][]byte, 2100)
 			for pow := uint32(0); pow < 21; pow++ {
 				for i := 0; i < 100; i++ {
-					bufs = append(bufs, p.Get(uint32(1<<pow)))
+					bufs = append(bufs, p.Get(1<<pow))
 				}
 			}
 			for _, b := range bufs {
-- 
GitLab