add new TestDialSelf

so that we exercise the dialWorker dial to self error path

dial_sync_test.go

@@ -270,3 +270,26 @@ func TestStressActiveDial(t *testing.T) {
 
 	wg.Wait()
 }
+
+func TestDialSelf(t *testing.T) {
+	ctx, cancel := context.WithCancel(context.Background())
+	defer cancel()
+
+	self := peer.ID("ABC")
+	s := NewSwarm(ctx, self, nil, nil)
+	defer s.Close()
+
+	ds := NewDialSync(s.dialWorker)
+
+	// this should fail
+	_, err := ds.DialLock(ctx, self)
+	if err != ErrDialToSelf {
+		t.Fatal("expected error from self dial")
+	}
+
+	// do it twice to make sure we get a new active dial object that fails again
+	_, err = ds.DialLock(ctx, self)
+	if err != ErrDialToSelf {
+		t.Fatal("expected error from self dial")
+	}
+}

dial_test.go

@@ -652,7 +652,7 @@ func TestDialSimultaneousJoin(t *testing.T) {
 	}
 }
 
-func TestDialSelf(t *testing.T) {
+func TestDialSelf2(t *testing.T) {
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
 
@@ -664,10 +664,4 @@ func TestDialSelf(t *testing.T) {
 	if err != ErrDialToSelf {
 		t.Fatal("expected error from self dial")
 	}
-
-	// do it twice to make sure we get a new active dial object that fails again
-	_, err = s1.DialPeer(ctx, s1.LocalPeer())
-	if err != ErrDialToSelf {
-		t.Fatal("expected error from self dial")
-	}
 }