Commit c34211a7 authored by Brian Tiger Chow's avatar Brian Tiger Chow

fix(bitswap) check for nil in public interface

parent 791637a5
package bitswap package bitswap
import ( import (
"errors"
context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context" context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
ds "github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/datastore.go" ds "github.com/jbenet/go-ipfs/Godeps/_workspace/src/github.com/jbenet/datastore.go"
...@@ -87,6 +89,9 @@ func (bs *bitswap) Block(parent context.Context, k u.Key) (*blocks.Block, error) ...@@ -87,6 +89,9 @@ func (bs *bitswap) Block(parent context.Context, k u.Key) (*blocks.Block, error)
// get better guarantees. May need shared sequence numbers. // get better guarantees. May need shared sequence numbers.
bs.strategy.MessageSent(p, message) bs.strategy.MessageSent(p, message)
if response == nil {
return
}
bs.ReceiveMessage(ctx, p, response) bs.ReceiveMessage(ctx, p, response)
}(i) }(i)
} }
...@@ -112,6 +117,12 @@ func (bs *bitswap) HasBlock(ctx context.Context, blk blocks.Block) error { ...@@ -112,6 +117,12 @@ func (bs *bitswap) HasBlock(ctx context.Context, blk blocks.Block) error {
func (bs *bitswap) ReceiveMessage( func (bs *bitswap) ReceiveMessage(
ctx context.Context, p *peer.Peer, incoming bsmsg.BitSwapMessage) ( ctx context.Context, p *peer.Peer, incoming bsmsg.BitSwapMessage) (
*peer.Peer, bsmsg.BitSwapMessage, error) { *peer.Peer, bsmsg.BitSwapMessage, error) {
if p == nil {
return nil, nil, errors.New("Received nil Peer")
}
if incoming == nil {
return nil, nil, errors.New("Received nil Message")
}
bs.strategy.MessageReceived(p, incoming) bs.strategy.MessageReceived(p, incoming)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment