Commit fc71f990 authored by Juan Batiz-Benet's avatar Juan Batiz-Benet

go-vet friendly codebase

- distinguish log.Error and log.Errorf functions
- Initialize structs with field names
- A bit of unreachable code (defers)
parent 4b21e4db
...@@ -88,13 +88,13 @@ func (bs *bitswap) Block(parent context.Context, k u.Key) (*blocks.Block, error) ...@@ -88,13 +88,13 @@ func (bs *bitswap) Block(parent context.Context, k u.Key) (*blocks.Block, error)
log.Debug("bitswap dialing peer: %s", p) log.Debug("bitswap dialing peer: %s", p)
err := bs.sender.DialPeer(p) err := bs.sender.DialPeer(p)
if err != nil { if err != nil {
log.Error("Error sender.DialPeer(%s)", p) log.Errorf("Error sender.DialPeer(%s)", p)
return return
} }
response, err := bs.sender.SendRequest(ctx, p, message) response, err := bs.sender.SendRequest(ctx, p, message)
if err != nil { if err != nil {
log.Error("Error sender.SendRequest(%s)", p) log.Errorf("Error sender.SendRequest(%s)", p)
return return
} }
// FIXME ensure accounting is handled correctly when // FIXME ensure accounting is handled correctly when
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment