Commits · 36798def1153020eae7fa7b53fba4b0856f392c6 · dms3 / go-bitswap

05 Dec, 2014 38 commits

tracking down a bug dhthell found, added asserts and better logging. · 36798def
Jeromy authored Nov 21, 2014

36798def
wire GetBlocks into blockservice · b5121d63
Jeromy authored Nov 21, 2014

b5121d63
test(bitswap) Close (but skip for now) · b90e5fb7
Brian Tiger Chow authored Nov 20, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
b90e5fb7
refactor(bitswap) group the deferreds · 58b9745f
Brian Tiger Chow authored Nov 20, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
58b9745f
fix(exchange) allow exchange to be closed · 26e6f28e
Brian Tiger Chow authored Nov 20, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
26e6f28e
fix(bitswap) signal termination to async'ly spawned workers · d6e2157a
Brian Tiger Chow authored Nov 20, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
d6e2157a
style(bitswap) name -> loop · 5045d096
Brian Tiger Chow authored Nov 20, 2014
```
eh?

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
5045d096
feat(bitswap) loop over all provided keys · 499aa2c3
Brian Tiger Chow authored Nov 20, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
499aa2c3

feat(bitswap) find providers for all keys on wantlist · 36ebde35

Brian Tiger Chow authored Nov 20, 2014

@jbenet @whyrusleeping

this addresses a failure case where

1) bitswap wants blocks A and B
2) partner 1 has A and partner 2 has B
3) We choose a key at random, drawing A.
4) Then, we request A, neglecting to find a provider for B.

Sending the full wantlist is meant to be used as a helpful additional
piece of data, but...

unless our hunch is support by statistical inference at runtime,
it's not safe to assume that a peer will have blocks for related keys.
Routing must be the source of truth.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

36ebde35

fix(bitswap/loop) add to wantlist just once · 6af9f417

Brian Tiger Chow authored Nov 20, 2014

oops

set Add is idempotent but it's a waste of resources

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

6af9f417

rename · 7d72132c

Brian Tiger Chow authored Nov 20, 2014

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

7d72132c

refactor(blockstore) mv under blocks/ · 08d0a11b

Brian Tiger Chow authored Nov 20, 2014

@jbenet @whyrusleeping

the pyramids were built one brick at a time

addresses: https://github.com/jbenet/go-ipfs/issues/370

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

08d0a11b

tests(bitswap) share code between the two large tests · 80244dac
Brian Tiger Chow authored Nov 20, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
80244dac
fix(bitswap) stop the ticker when the run loop exits · fd8e2b3a
Brian Tiger Chow authored Nov 19, 2014
```
@whyrusleeping

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
fd8e2b3a

feat(bitswap) implement GetBlocks · 2a4a6d3e

Brian Tiger Chow authored Nov 19, 2014

@whyrusleeping @jbenet

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

2a4a6d3e

refactor(bitswap) move wantlist to loop receive · 470b02d4
Brian Tiger Chow authored Nov 19, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
470b02d4

tests(bitswap) share constructor between tests · 12b83ff8

Brian Tiger Chow authored Nov 19, 2014

@whyrusleeping i hope this makes it a bit easier to work with tests

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

12b83ff8

feat(bitswap/notifications) Subscribe to multiple keys · 8a87b709
Brian Tiger Chow authored Nov 19, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
8a87b709
style(bitswap/notifications) make it more obvious · 140a141c
Brian Tiger Chow authored Nov 19, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
140a141c
randomize rebroadcast target · 6ee1fe5e
Jeromy authored Nov 20, 2014

6ee1fe5e
remove buffer timing in bitswap in favor of manual batching · 26f78574
Jeromy authored Nov 20, 2014

26f78574
fix tests halting · 44f32138
Jeromy authored Nov 19, 2014

44f32138
move some variables into strategy · c6af3fe4
Jeromy authored Nov 19, 2014

c6af3fe4
added a new test for a dhthell scenario that was failing · e3bf5cd8
Jeromy authored Nov 19, 2014

e3bf5cd8
misc(bitswap) renaming · eaa7a9d5
Brian Tiger Chow authored Nov 19, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
eaa7a9d5

simplify · 0163be78

Brian Tiger Chow authored Nov 18, 2014

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

0163be78

some renaming · 599e3088
Brian Tiger Chow authored Nov 18, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
599e3088
constify to make it clear what _can_ and _can't_ change over time · 3f6bbecc
Brian Tiger Chow authored Nov 18, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
3f6bbecc

naming · 9cad93a8

Brian Tiger Chow authored Nov 18, 2014

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

9cad93a8

clarify MessageReceived contract · a82ac0a9
Brian Tiger Chow authored Nov 18, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
a82ac0a9
use event logger here too? · 56726e02
Brian Tiger Chow authored Nov 18, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
56726e02

fix(log) ->f · aca2566d

Brian Tiger Chow authored Nov 18, 2014

@whyrusleeping

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

aca2566d

fix(bitswap) consistent event names · a4ccbf39

Brian Tiger Chow authored Nov 18, 2014

@whyrusleeping @jbenet

since the logger is created with package scope, don't need to specify
the package name in event messages

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

a4ccbf39

fix(bitswap) handle error · c0decfc9

Brian Tiger Chow authored Nov 18, 2014

@whyrusleeping

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

c0decfc9

events(bitswap) try the new event logger in the bitswap GetBlock method · 40f3a6a6

Brian Tiger Chow authored Nov 18, 2014

@jbenet
@whyrusleeping

Let me know if you want to direct the eventlog output to _both_ the file
and stderr. Right now it goes to file. Perhaps this is just a minor bip
in the larger discussion around log levels.

https://github.com/jbenet/go-ipfs/issues/292

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

40f3a6a6

test(bitswap) · ca31457d

Brian Tiger Chow authored Nov 18, 2014

@whyrusleeping This appears to be a timing issue. The asynchronous
nature of the new structure provides has the bitswap waiting on the
context a bit more. This isn't a problem at all, but in this test, it
makes the functions return in an inconveniently timely manner.

TODO don't let the test depend on time.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

ca31457d

dont panic on empty wantlist · 709075f7
Jeromy authored Nov 18, 2014

709075f7
beginnings of a bitswap refactor · fefe7d37
Jeromy authored Nov 18, 2014

fefe7d37

25 Nov, 2014 2 commits
- fix(bitswap) shutdown · b0e60a69
  Brian Tiger Chow authored Nov 20, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  b0e60a69
- fix(bitswap/notifications) don't force sender to block on receiver · eeffc3a5
  Brian Tiger Chow authored Nov 19, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  eeffc3a5