Skip to content

GitLab

Switch branch/tag
  1. 31 Jan, 2016 2 commits
  3. 30 Jan, 2016 3 commits
  5. 12 Jan, 2016 4 commits
  7. 14 Dec, 2015 1 commit
  9. 05 Nov, 2015 1 commit
  11. 27 Oct, 2015 1 commit
  13. 23 Oct, 2015 1 commit
  15. 18 Oct, 2015 1 commit
  17. 12 Oct, 2015 1 commit
  19. 03 Oct, 2015 1 commit
  21. 25 Sep, 2015 1 commit
  23. 16 Sep, 2015 1 commit
  25. 15 Sep, 2015 2 commits
  27. 09 Sep, 2015 2 commits
  29. 05 Sep, 2015 1 commit
  31. 23 Aug, 2015 2 commits
  33. 04 Aug, 2015 1 commit
    • Juan Batiz-Benet's avatar
      bitswap/provide: improved rate limiting · 06b49918
      Juan Batiz-Benet authored 
      this PR greatly speeds up providing and add.

(1) Instead of idling workers, we move to a ratelimiter-based worker.
We put this max at 512, so that means _up to_ 512 goroutines. This
is very small load on the node, as each worker is providing to the
dht, which means mostly waiting. It DOES put a large load on the DHT.
but i want to try this out for a while and see if it's a problem.
We can decide later if it is a problem for the network (nothing
stops anyone from re-compiling, but the defaults of course matter).

(2) We add a buffer size for provideKeys, which means that we block
the add process much less. this is a very cheap buffer, as it only
stores keys (it may be even cheaper with a lock + ring buffer
instead of a channel...). This makes add blazing fast-- it was being
rate limited by providing. Add should not be ratelimited by providing
(much, if any) as the user wants to just store the stuff in the local
node's repo. This buffer is initially set to 4096, which means:

  4096 * keysize (~258 bytes + go overhead) ~ 1-1.5MB

this buffer only last a few sec to mins, and is an ok thing to do
for the sake of very fast adds. (this could be a configurable
paramter, certainly for low-mem footprint use cases). At the moment
this is not much, compared to block sizes.

(3) We make the providing EventBegin() + Done(), so that we can
track how long a provide takes, and we can remove workers as they
finish in bsdash and similar tools.

License: MIT
Signed-off-by: default avatarJuan Batiz-Benet <juan@benet.ai>
      06b49918
  35. 16 Jul, 2015 1 commit
  37. 14 Jul, 2015 3 commits
  39. 13 Jul, 2015 2 commits
  41. 10 Jul, 2015 1 commit
  43. 07 Jul, 2015 1 commit
  45. 18 Jun, 2015 2 commits
  47. 12 Jun, 2015 2 commits
  49. 11 Jun, 2015 2 commits