GitLab

new Service interface

and other logging switches. I kept the u.PErr and u.POut in cli
commands, as those do need to write raw output directly.

We'll want a `type blocks.Block interface {}` later, but
for now, make sure Blockstore uses ptrs for both Get and Put.

+ fix NewBlock output compile error

Rather than pushing errors back down to lower layers, propagate the
errors upward.

This commit adds a `ReceiveError` method to BitSwap's network receiver.

Still TODO: rm the error return value from:

    net.service.handler.HandleMessage

This is inspired by delegation patterns in found in the wild.

true -> always send to peer

false -> use ledger-based strategy described in IPFS paper draft 3

fix(bitswap) pass go vet

fixes #97

https://github.com/jbenet/go-ipfs/issues/97

changing the bitswap interace breaks tests and makes things a bit
difficult going forward. I think I have a temporary solution to replace
the async method.

this commit partially reverts changes from:

ec50703395098f75946f0bad01816cc54ab18a58

https://github.com/jbenet/go-ipfs/commit/ec50703395098f75946f0bad01816cc54ab18a58

@perfmode using non-async version as apparently there's
a bug in async. will look into it.

@perfmode boom

fix(bitswap) Put synchronously. Then notify async

style(exch:bitswap) rename NetMessage adapter impl

yay deleting code.

@jbenet oh hai there!

examples:

    http://golang.org/pkg/container/heap/#Interface

    http://golang.org/pkg/net/#Interface

    http://golang.org/pkg/sort/#Interface

Move go-ipfs/bitswap package to go-ipfs/exchange/bitswap

* Delineates the difference between the generic exchange interface and
  implementations (eg. BitSwap protocol)

  Thus, the bitswap protocol can be refined without having to overthink
  how future exchanges will work. Aspects common to BitSwap and other
  exchanges can be extracted out to the exchange package in piecemeal.

  Future exchange implementations can be placed in sibling packages next
  to exchange/bitswap. (eg. exchange/multilateral)