GitLab

remove 'adapter' concept
instead, describe the component as the bitswap network

it's still an adapter, but it's just not necessary to describe it as
such

https://github.com/jbenet/go-ipfs/issues/270#issuecomment-61826022

to emphasize idempotence

comes at the cost of O(n) Blocks() method.

so there's one less name to think about

A nice invariant for bitswap sessions:

        Senders and receivers can trust that messages do not contain
        duplicate blocks or duplicate keys. Backing the message with a
        map enforces this invariant.

        This comes at the cost of O(n) getters.

implementation will be patched to ensure bitswap messages cannot contain
duplicate blocks or keys

@whyrusleeping noticed this a couple days ago

potential long-term fix: prevent duplicate entries in the wantlist by
using a map/set and iterating over this data structure on export

- distinguish log.Error and log.Errorf functions
- Initialize structs with field names
- A bit of unreachable code (defers)

addresses concurrent access in bitswap session

fixes data race detected in a testnet test

![](http://m.memegen.com/77n7dk.jpg)

(that wasn't mine :p)