Commit 821e151c authored by Jeromy's avatar Jeromy

remove hex encoding from flatfs

parent 6e446b05
...@@ -4,7 +4,6 @@ ...@@ -4,7 +4,6 @@
package flatfs package flatfs
import ( import (
"encoding/hex"
"errors" "errors"
"io/ioutil" "io/ioutil"
"os" "os"
...@@ -33,8 +32,8 @@ var ( ...@@ -33,8 +32,8 @@ var (
type Datastore struct { type Datastore struct {
path string path string
// length of the dir splay prefix, in bytes of hex digits // length of the dir splay prefix
hexPrefixLen int prefixLen int
// sychronize all writes and directory changes for added safety // sychronize all writes and directory changes for added safety
sync bool sync bool
...@@ -47,21 +46,19 @@ func New(path string, prefixLen int, sync bool) (*Datastore, error) { ...@@ -47,21 +46,19 @@ func New(path string, prefixLen int, sync bool) (*Datastore, error) {
return nil, ErrBadPrefixLen return nil, ErrBadPrefixLen
} }
fs := &Datastore{ fs := &Datastore{
path: path, path: path,
// convert from binary bytes to bytes of hex encoding prefixLen: prefixLen,
hexPrefixLen: prefixLen * hex.EncodedLen(1), sync: sync,
sync: sync,
} }
return fs, nil return fs, nil
} }
var padding = strings.Repeat("_", maxPrefixLen*hex.EncodedLen(1)) var padding = strings.Repeat("_", maxPrefixLen)
func (fs *Datastore) encode(key datastore.Key) (dir, file string) { func (fs *Datastore) encode(key datastore.Key) (dir, file string) {
safe := hex.EncodeToString(key.Bytes()[1:]) prefix := (key.String() + padding)[:fs.prefixLen]
prefix := (safe + padding)[:fs.hexPrefixLen]
dir = path.Join(fs.path, prefix) dir = path.Join(fs.path, prefix)
file = path.Join(dir, safe+extension) file = path.Join(dir, key.String()+extension)
return dir, file return dir, file
} }
...@@ -70,11 +67,7 @@ func (fs *Datastore) decode(file string) (key datastore.Key, ok bool) { ...@@ -70,11 +67,7 @@ func (fs *Datastore) decode(file string) (key datastore.Key, ok bool) {
return datastore.Key{}, false return datastore.Key{}, false
} }
name := file[:len(file)-len(extension)] name := file[:len(file)-len(extension)]
k, err := hex.DecodeString(name) return datastore.NewKey(name), true
if err != nil {
return datastore.Key{}, false
}
return datastore.NewKey(string(k)), true
} }
func (fs *Datastore) makePrefixDir(dir string) error { func (fs *Datastore) makePrefixDir(dir string) error {
......
...@@ -152,8 +152,8 @@ func TestStorage(t *testing.T) { ...@@ -152,8 +152,8 @@ func TestStorage(t *testing.T) {
defer cleanup() defer cleanup()
const prefixLen = 2 const prefixLen = 2
const prefix = "7175" const prefix = "q"
const target = prefix + string(os.PathSeparator) + "71757578.data" const target = prefix + string(os.PathSeparator) + "quux.data"
fs, err := flatfs.New(temp, prefixLen, false) fs, err := flatfs.New(temp, prefixLen, false)
if err != nil { if err != nil {
t.Fatalf("New fail: %v\n", err) t.Fatalf("New fail: %v\n", err)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment