GitLab

MapDatastore: obey KeysOnly

fix the keytransform datastore's query implementation

We use this datastore in tests all the time so it should match the behavior of
_actual_ datastores as much as possible.

The namespace Datastore shouldn't have to touch the mess with the query.

Note: this _also_ correctly applies ordering, filters, etc. to the transformed
keys (in both the namespaced and the key transform datastores).

Motivation: I want to be able to use the concrete type from a different package
but I can't.

This:

1. Exports the concrete datastore type and avoids returning private types from
   public functions.
2. Removes the mostly useless ktds interface. Unfortunately, it collides with
   the idiomatic name for the datastore itself.

This could break something referencing the `ktds.Datastore` type but nothing is
doing that.

sync: apply entire query while locked

filter: values are now always bytes

autobatch: batch deletes

part of fixing: https://github.com/libp2p/go-libp2p-kad-dht/issues/316#issuecomment-482753415

cleanup and optimize naive query filters

It's impossible to cancel this correctly. This patch also tries to avoid
goroutines whenever possible.

Fix – sorted limited offset mount queries

Fix function comments based on best practices from Effective Go