commands/http: Respond with error if encoding option isn't a string

4e02ae9d · Matt Bell · Juan Batiz-Benet · a14ee931 · 4e02ae9d
Commit 4e02ae9d authored Nov 03, 2014 by Matt Bell Committed by Juan Batiz-Benet Nov 04, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

http/handler.go http/handler.go +6 -1

No files found.
--- a/http/handler.go
+++ b/http/handler.go
@@ -43,7 +43,12 @@ func (i Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set("Content-Type", "application/octet-stream")
 	} else {
 		enc, _ := req.Option(cmds.EncShort)
-		mime := mimeTypes[enc.(string)]
+		encStr, ok := enc.(string)
+		if !ok {
+			w.WriteHeader(http.StatusInternalServerError)
+			return
+		}
+		mime := mimeTypes[encStr]
 		w.Header().Set("Content-Type", mime)
 	}