Commit 4e484d22 authored by keks's avatar keks

better logging, errors, fmt

parent 0e8aad8b
...@@ -76,7 +76,7 @@ func (c *Command) Call(req *Request, re ResponseEmitter, env Environment) { ...@@ -76,7 +76,7 @@ func (c *Command) Call(req *Request, re ResponseEmitter, env Environment) {
err := c.call(req, re, env) err := c.call(req, re, env)
if err != nil { if err != nil {
log.Debug("error occured in call, closing with error: %s", err) log.Debugf("error occured in call, closing with error: %s", err)
} }
closeErr = re.CloseWithError(err) closeErr = re.CloseWithError(err)
......
...@@ -94,7 +94,7 @@ func MakeTypedEncoder(f interface{}) func(*Request) func(io.Writer) Encoder { ...@@ -94,7 +94,7 @@ func MakeTypedEncoder(f interface{}) func(*Request) func(io.Writer) Encoder {
return MakeEncoder(func(req *Request, w io.Writer, i interface{}) error { return MakeEncoder(func(req *Request, w io.Writer, i interface{}) error {
if reflect.TypeOf(i) != valType { if reflect.TypeOf(i) != valType {
return fmt.Errorf("unexpected type: %T", i) return fmt.Errorf("unexpected type %T, expected %v", i, valType)
} }
out := val.Call([]reflect.Value{ out := val.Call([]reflect.Value{
......
...@@ -114,7 +114,9 @@ func (re *writerResponseEmitter) CloseWithError(err error) error { ...@@ -114,7 +114,9 @@ func (re *writerResponseEmitter) CloseWithError(err error) error {
return re.Close() return re.Close()
} }
cwe, ok := re.c.(interface{ CloseWithError(error) error }) cwe, ok := re.c.(interface {
CloseWithError(error) error
})
if ok { if ok {
re.closed = true re.closed = true
return cwe.CloseWithError(err) return cwe.CloseWithError(err)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment