Combine Allow headers in a single comma separated list

f36ceb1e · Sawood Alam · Steven Allen · a29b26be · f36ceb1e
Commit f36ceb1e authored Apr 29, 2020 by Sawood Alam Committed by Steven Allen Apr 29, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 4 deletions

http/handler.go http/handler.go +4 -4

No files found.
--- a/http/handler.go
+++ b/http/handler.go
@@ -5,6 +5,7 @@ import (
 	"errors"
 	"net/http"
 	"runtime/debug"
+	"strings"
 	"sync"
 	"time"
@@ -192,10 +193,9 @@ func (h *handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 }
 func setAllowedHeaders(w http.ResponseWriter, allowGet bool) {
-	w.Header().Add("Allow", http.MethodOptions)
+	allowedMethods := []string{http.MethodOptions, http.MethodPost}
-	w.Header().Add("Allow", http.MethodPost)
 	if allowGet {
-		w.Header().Add("Allow", http.MethodHead)
+		allowedMethods = append(allowedMethods, http.MethodHead, http.MethodGet)
-		w.Header().Add("Allow", http.MethodGet)
 	}
+	w.Header().Set("Allow", strings.Join(allowedMethods, ", "))
 }