GitLab

testing: add tests for constructing Options with defaults and parsing those Options using the CLI parsing tools

* Staticcheck fixes

This fixes all staticcheck warnings for this library.

We introduced a bug where we forgot to do this and couldn't find the definition
for the option.

This _also_ fixes (and tests) a bug where we'd allow duplicate flags in some
cases.

- first step toward implementing file ignore

feat(file-ignore): implement file ignore

- add flags for providing a gitignore and/or list of files to ignore
- construct a filter to be passed to a SerialFile

feat(file-ignore): use go-ipfs-files fork; use renamed constructor

feat(file-ignore): test case w. ignore rules; refactor parseArgs

feat(file-ignore): ignore-rule opt is open-ended

- make ignore-rules options accept a path to a file
- add test case for ignore rules file

feat(file-ignore): help-text for variardic opts

- show StringsOption as variardic option in help-text
- add test case for variardic option

feat(file-ignore): rename rulesfile opt; fix typos

feat(file-ignore): temp replace of go-ipfs-files

- temporarily using go-ipfs-files fork until go-ipfs-files#26 is merged
- trying to get ci/cd builds working
- will revert before merging

feat(file-ignore): refactor cli/parse.go#setOpts

feat(file-ignore): cleanup parse.go; add test-case

feat(file-ignore): update ignore option copytext

feat(file-ignore): check opt against `optDef.Type`

- revert exclusion of options with `Strings` type,
so those option values are typechecked
- add command test cases

feat(file-ignore): add test-case w. hidden file

feat(file-ignore): build against go-ipfs-files@latest

feat(file-ignore): update go.mod/go.sum

License: MIT
Signed-off-by: Dominic Della Valle <ddvpublic@gmail.com>

This is also done in the Executor. Unfortunately, doing this *here* causes us to
block until we get an argument from stdin, even if we're handling a help call.

(and test)

Also, make it easier to actually use ParseBodyArguments. Now it only returns an
error when something actually goes wrong.

These aren't placeholder contexts.

License: MIT
Signed-off-by: Jeromy <why@ipfs.io>

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

License: MIT
Signed-off-by: Thomas Gardner <tmg@fastmail.com>

With verbose flag:
* remove EnableStdin() flags on all StringArg,

* remove all unneeded parsing code for StringArg, and print an
* informative message if `ipfs` begins reading from a CharDevice,

* remove broken go tests for EnableStdin cli parsing, and add some
* trivial test cases for reading FileArg from stdin,

* add a panic to prevent EnableStdin from being set on
* StringArg in the future.

Resolves: #2877, #2870
License: MIT
Signed-off-by: Thomas Gardner <tmg@fastmail.com>

License: MIT
Signed-off-by: Thomas Gardner <tmg@fastmail.com>

parseOpts now does some preliminary path screening to prevent
command sequences like

	`ipfs <hash> cat`

from succeeding. The tests affected by this have been slightly altered,
but should be restored once parseOpts is decoupled from path analysis.

Command suggestion printing has also been factored into a single
function.

Fixes: #2501
License: MIT
Signed-off-by: Thomas Gardner <tmg@fastmail.com>

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>

License: MIT
Signed-off-by: ForrestWeston <Forrest.Weston@gmail.com>

License: MIT
Signed-off-by: ForrestWeston <Forrest.Weston@gmail.com>

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>