1. 29 Apr, 2020 1 commit
  2. 04 Apr, 2020 1 commit
    • Steven Allen's avatar
      change HandledMethods to AllowGet and cleanup method handling · 3093cad8
      Steven Allen authored
      Allowing methods isn't as simple as just allowing/disallowing them because
      different methods do different things.
      
      * HEAD: should be allowed everywhere GET is allowed.
      * OPTIONS:
        * When a CORS request is made, this will be handled by the CORS library.
        * Otherewise, we need to return the allowed methods.
      * POST: always allowed.
      * Everything else: always denied.
      
      Changing HandledMethods to a simple AllowGet makes it easier to "do the right
      thing".
      3093cad8
  3. 11 May, 2019 1 commit
  4. 19 Feb, 2019 1 commit
  5. 13 Dec, 2018 3 commits
  6. 26 Oct, 2018 1 commit
    • Steven Allen's avatar
      fix encoding/decoding again · cfa895bf
      Steven Allen authored
      This time, we completely separate error encoding and let the emitter deal with it. Basically:
      
      1. Some transports won't even use the same channel.
      2. We don't *have* an error "encoder" for protobuf.
      
      We now *finally* return the correct content type (json) when returning an error after passing `--enc=protobuf`.
      
      This *also*:
      
      1. Removes GetDecoder. We need to special case this every time anyways.
      2. Allows transports to specify the "default" encoding type instead of assuming JSON.
      3. Ensure that we never mistake a value for an error in the HTTP transport by converting to a cmdkit.Error *before* passing errors to `doPreamble`.
      cfa895bf
  7. 25 Oct, 2018 1 commit
  8. 07 Sep, 2018 1 commit
  9. 31 Aug, 2018 1 commit
  10. 23 Aug, 2018 18 commits
  11. 16 Feb, 2018 1 commit
    • Steven Allen's avatar
      cleaner command completion/calling · 294e20f6
      Steven Allen authored
      **Returning errors/calling:**
      
      Instead of having a dance where we:
        * Close the response emitter immediately if the command succeeds.
        * Return an error, call SetError, and then close the response emitter if it
          fails.
      
      Just set the error from within the `Call` command and always close the response
      emitter.
      
      **Doner**
      
      Get rid of the Done channel/doner interface from the response emitter. We close
      the response emitter after finishing the Call *anyways* so this channel isn't
      necessary (anymore, at least).
      294e20f6
  12. 11 Jan, 2018 1 commit
  13. 21 Dec, 2017 1 commit
  14. 12 Dec, 2017 1 commit
  15. 11 Dec, 2017 1 commit
  16. 08 Dec, 2017 1 commit
  17. 07 Dec, 2017 1 commit
  18. 28 Oct, 2017 1 commit
  19. 26 Oct, 2017 1 commit
  20. 23 Oct, 2017 1 commit
  21. 19 Oct, 2017 1 commit