Commits · b0ed3647898ea799cd62de4ad7ef4ced2aad469b · dms3 / go-dms3-cmds

02 Aug, 2015 1 commit

fix cors: defaults should take the port of the listener · b0ed3647

Juan Batiz-Benet authored Jul 31, 2015

need to do it this way to avoid VERY confusing situations where
the user would change the API port (to another port, or maybe even
to :0). this way things dont break on the user, and by default,
users only need to change the API address and things should still
"just work"

License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>

b0ed3647

29 Jul, 2015 10 commits

Merge pull request #1539 from ipfs/log-api-route · 4985bf13
Juan Benet authored Jul 29, 2015
```
fix log tail command
```
4985bf13
should fix issue where 'read on closed body' error was leaking down · cea426ac
Jeromy authored Jul 29, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
cea426ac
cancel contexts when client disconnects · 96964fc5
Jeromy authored Jul 29, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
96964fc5

add -w improvement: wrap multiple files in one dir · de43ad61

Juan Batiz-Benet authored Jul 29, 2015

  > ipfs add a b c
  added Qmbvkmk9LFsGneteXk3G7YLqtLVME566ho6ibaQZZVHaC9 a
  added QmR9pC5uCF3UExca8RSrCVL8eKv7nHMpATzbEQkAHpXmVM b
  added QmetGxZTgo8tYAKQH1KLsY13MxqeVHbxYVmvzBzJAKU6Z7 c
  added QmXg3WHLcjnz4ejeYF6FKVBkb4m1oKjQmF5fEWL9M1uQF3

  > ipfs ls QmXg3WHLcjnz4ejeYF6FKVBkb4m1oKjQmF5fEWL9M1uQF3
  Qmbvkmk9LFsGneteXk3G7YLqtLVME566ho6ibaQZZVHaC9 10 a
  QmR9pC5uCF3UExca8RSrCVL8eKv7nHMpATzbEQkAHpXmVM 10 b
  QmetGxZTgo8tYAKQH1KLsY13MxqeVHbxYVmvzBzJAKU6Z7 10 c

License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>

de43ad61

more serious CORS tests. · e6f4b474

Juan Batiz-Benet authored Jul 28, 2015

this commit introduces more serious CORS tests that check
status response codes, and run real HTTP requests.

License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>

e6f4b474

fix API handler to respect referer + exit on CORS · 8c28a1c2

Juan Batiz-Benet authored Jul 28, 2015

this commit makes the API handler short circuit the request if the
CORS headers say its not allowed. (the CORS handler only sets the
headers, but does not short-circuit)

It also makes the handler respect the referer again. See security
discussion at https://github.com/ipfs/go-ipfs/issues/1532

License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>

8c28a1c2

address CR comment re interface in cmds http handler · 0cd37df2

Juan Batiz-Benet authored Jul 28, 2015

https://github.com/ipfs/go-ipfs/pull/1529#discussion_r35662230

License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>

0cd37df2

implement arbitrary HTTP header support · 135e1fc4

Juan Batiz-Benet authored Jul 28, 2015

this commit adds the ability to specify arbitrary HTTP headers
for either the Gateway or the API. simply set the desired headers
on the config:

    ipfs config --json API.HTTPHeaders.X-MyHdr '["meow :)"]'
    ipfs config --json Gateway.HTTPHeaders.X-MyHdr '["meow :)"]'

License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>

135e1fc4

cmds/http: remove referrer check · 95c735b4

Juan Batiz-Benet authored Jul 28, 2015

it used to be here for a CSRF check. but we now have CORS checks.

License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>

95c735b4

Added API + Gateway support for arbitrary HTTP headers · c077fea5
Juan Batiz-Benet authored Jul 23, 2015
```
This commit fixes + improves CORS support

License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>
```
c077fea5

28 Jul, 2015 5 commits
- Merge pull request #1531 from ipfs/fix/stream-header · a9dba10f
  Juan Benet authored Jul 28, 2015
```
only set stream header on streamed output
```
  a9dba10f
- put comment back · 69e9c5ef
  Jeromy Johnson authored Jul 28, 2015
  
  69e9c5ef
- Better error message on unrecognized command · e2371c59
  Shaun Bruce authored Jul 12, 2015
```
Closes issue #1436

License: MIT
Signed-off-by: Shaun Bruce <shaun.m.bruce@gmail.com>
```
  e2371c59
- only set stream header on streamed output · 9d48414f
  Jeromy authored Jul 28, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
  9d48414f
- naming and cleanup · ac1db70e
  Jeromy authored Jul 27, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
  ac1db70e
27 Jul, 2015 2 commits
- comment need for custom client · 9833318e
  Jeromy authored Jul 27, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
  9833318e
- address comments from CR and fix random failures · 6cec3660
  Jeromy authored Jul 27, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
  6cec3660
26 Jul, 2015 3 commits
- some commenting · 7573da7e
  Jeromy authored Jul 26, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
  7573da7e
- refactor http client code · 13bf48e4
  Jeromy authored Jul 25, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
  13bf48e4
- better refactor of http handler code · 986b012c
  Jeromy authored Jul 25, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
  986b012c
25 Jul, 2015 1 commit

implement http trailers for errors after headers are sent · 22fd0e5d

Jeromy authored Jul 24, 2015

refactor http handler and copyChunks to get this all to work correctly
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>

22fd0e5d

24 Jul, 2015 2 commits

cmds/http/handler: set stream error trailer · 6a838c58

Juan Batiz-Benet authored Jul 24, 2015

stream output might break. in these cases we need to notify the
client. this is after a 200 response has been sent. We do this
by setting a special trailer (header after the body):

  X-Stream-Error: <error cause>

This is similar to what's done by systems like gRPC. This still
needs to be read + handled on the other side.

License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>

6a838c58

http/client: log errors when stream copy fails · 59e66c97
Juan Batiz-Benet authored Jul 24, 2015
```
License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>
```
59e66c97

22 Jul, 2015 1 commit
- attempt at properly closing http response bodies · ce39ca86
  Jeromy authored Jul 22, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
  ce39ca86
21 Jul, 2015 2 commits
- if no context set in request, use context.TODO() · 15bbfb15
  Jeromy authored Jul 20, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
  15bbfb15
- remove context from context · 2b99f038
  Jeromy authored Jul 20, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
  2b99f038
20 Jul, 2015 2 commits
- make offline commands respect timeout · 356fa871
  Jeromy authored Jul 20, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
  356fa871
- add a global timeout flag for to be setting timeouts · 00bc0f1d
  Jeromy authored Jul 20, 2015
```
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
```
  00bc0f1d
09 Jul, 2015 1 commit
- Add hidden file support to add · a9a052ec
  gatesvp authored Jul 06, 2015
```
License: MIT
Signed-off-by: Gaetan Voyer-Perrault <gatesvp@gmail.com>
```
  a9a052ec
13 Jun, 2015 1 commit

core/commands/unixfs/ls: Don't recurse into chunked files · 7b3973db

W. Trevor King authored Jun 09, 2015

Folks operating at the Unix-filesystem level shouldn't care about that
level of Merkle-DAG detail.  Before this commit we had:

  $ ipfs unixfs ls /ipfs/QmSRCHG21Sbqm3EJG9aEBo4vS7Fqu86pAjqf99MyCdNxZ4/busybox
  /ipfs/QmSRCHG21Sbqm3EJG9aEBo4vS7Fqu86pAjqf99MyCdNxZ4/busybox:
  ... several lines of empty-string names ...

And with this commit we have:

  $ ipfs unixfs ls /ipfs/QmSRCHG21Sbqm3EJG9aEBo4vS7Fqu86pAjqf99MyCdNxZ4/busybox
  /ipfs/QmSRCHG21Sbqm3EJG9aEBo4vS7Fqu86pAjqf99MyCdNxZ4/busybox

I also reworked the argument-prefixing (object.Argument) in the output
marshaller to avoid redundancies like:

  $ ipfs unixfs ls /ipfs/QmSRCHG21Sbqm3EJG9aEBo4vS7Fqu86pAjqf99MyCdNxZ4/busybox
  /ipfs/QmSRCHG21Sbqm3EJG9aEBo4vS7Fqu86pAjqf99MyCdNxZ4/busybox:
  /ipfs/QmSRCHG21Sbqm3EJG9aEBo4vS7Fqu86pAjqf99MyCdNxZ4/busybox

As a side-effect of this rework, we no longer have the trailing blank
line that we used to have after the final directory listing.

The new ErrImplementation is like Python's NotImplementedError, and is
mostly a way to guard against external changes that would need
associated updates in this code.  For example, once we see something
that's neither a file nor a directory, we'll have to update the switch
statement to handle those objects.

License: MIT
Signed-off-by: W. Trevor King <wking@tremily.us>

7b3973db

26 May, 2015 1 commit
- Replace 'var * bytes.Buffer' with '\1 := new(bytes.Buffer)' · 3875facd
  rht authored May 26, 2015
  
  3875facd
20 May, 2015 5 commits

parse: fix parsing optional arg with stdin · 58070eef
Christian Couder authored May 21, 2015
```
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
```
58070eef
parse_test: test command with optional arg · d5bbb90e
Christian Couder authored May 20, 2015
```
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
```
d5bbb90e
parse: improve stdin fix · 1aca80b5
Christian Couder authored May 20, 2015
```
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
```
1aca80b5

parse: fix handling of unwanted stdin · 239ce331

Lars Gierth authored May 20, 2015

There can be non-terminal (i.e. non-interactive) sessions
that are *not* a pipe, for example:

	ssh user@host ipfs version

In this case, it looks like we should read from stdin.
Parsing stdin is accomplished by deliberately triggering
the parsing loop once.

We didn't previously check whether there is an ArgDef to support
that loop iteration.

239ce331

parse_test: test unwanted stdin · 528179e0
Lars Gierth authored May 20, 2015

528179e0

19 May, 2015 1 commit
- Merge pull request #1239 from rht/master · ce478f57
  Juan Batiz-Benet authored May 19, 2015
```
Add gofmt check
```
  ce478f57
18 May, 2015 1 commit
- Run 'gofmt -s -w' on these files · 0b2b9309
  rht authored May 19, 2015
  
  0b2b9309
17 May, 2015 1 commit
- parse_test: test stdin enabled and not variadic arg · ccd7dbb2
  Christian Couder authored May 18, 2015
```
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
```
  ccd7dbb2