- 17 Mar, 2018 5 commits
-
-
Steven Allen authored
-
Steven Allen authored
-
Steven Allen authored
(and test)
-
Steven Allen authored
-
Steven Allen authored
Also, make it easier to actually use ParseBodyArguments. Now it only returns an error when something actually goes wrong.
-
- 03 Mar, 2018 1 commit
-
-
Steven Allen authored
fix: improve cli/run to return errors and exit code
-
- 28 Feb, 2018 2 commits
-
-
dignifiedquire authored
-
dignifiedquire authored
-
- 21 Feb, 2018 1 commit
-
-
Steven Allen authored
-
- 20 Feb, 2018 2 commits
-
-
Steven Allen authored
cleaner command completion/calling
-
Whyrusleeping authored
handle both cmdkit.Error and *cmdkit.Error in ChanResponse
-
- 17 Feb, 2018 1 commit
-
-
Steven Allen authored
-
- 16 Feb, 2018 2 commits
-
-
Steven Allen authored
**Returning errors/calling:** Instead of having a dance where we: * Close the response emitter immediately if the command succeeds. * Return an error, call SetError, and then close the response emitter if it fails. Just set the error from within the `Call` command and always close the response emitter. **Doner** Get rid of the Done channel/doner interface from the response emitter. We close the response emitter after finishing the Call *anyways* so this channel isn't necessary (anymore, at least).
-
Steven Allen authored
fixes https://github.com/ipfs/go-ipfs/issues/4683
-
- 09 Feb, 2018 3 commits
-
-
Whyrusleeping authored
Better arrays
-
Jeromy authored
-
Jeromy authored
-
- 03 Feb, 2018 1 commit
-
-
Steven Allen authored
testing
-
- 02 Feb, 2018 1 commit
-
-
Jeromy authored
-
- 01 Feb, 2018 1 commit
-
-
Steven Allen authored
-
- 28 Jan, 2018 1 commit
-
-
Steven Allen authored
-
- 20 Jan, 2018 1 commit
-
-
Steven Allen authored
-
- 19 Jan, 2018 3 commits
-
-
Whyrusleeping authored
Don't handle timeouts in Execute.
-
Steven Allen authored
-
Steven Allen authored
Instead, handle it at the boundaries (in ServeHTTP and the CLI's Run function). This ensures that we actually *wait* to finish writing everything before canceling the context.
-
- 11 Jan, 2018 10 commits
-
-
Steven Allen authored
-
Steven Allen authored
always cancel the request context when calling reqCancel
-
Steven Allen authored
First check for HEAD request, then error out if writer is nil
-
keks authored
-
Steven Allen authored
Also, fix a nil pointer error.
-
Steven Allen authored
[RFC] don't generate a stack trace for every command
-
Whyrusleeping authored
use reflection to make writing commands nicer
-
Steven Allen authored
-
Steven Allen authored
We can add these back if we need them but, at the very least, we shouldn't be unconditionally generating stack traces on `Close`.
-
Jeromy authored
-
- 10 Jan, 2018 1 commit
-
-
Jeromy authored
-
- 09 Jan, 2018 2 commits
-
-
Jeromy authored
-
Whyrusleeping authored
Blocked - Changes for cmds 1.0
-
- 08 Jan, 2018 2 commits
-
-
Steven Allen authored
-
Steven Allen authored
It's slow and this code isn't platform dependent.
-