GitLab

build(deps): bump github.com/rs/cors from 1.6.0 to 1.7.0

Bumps [github.com/rs/cors](https://github.com/rs/cors) from 1.6.0 to 1.7.0.
- [Release notes](https://github.com/rs/cors/releases)
- [Commits](https://github.com/rs/cors/compare/v1.6.0...v1.7.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

build(deps): bump github.com/ipfs/go-ipfs-files from 0.0.2 to 0.0.4

Bumps [github.com/ipfs/go-ipfs-files](https://github.com/ipfs/go-ipfs-files) from 0.0.2 to 0.0.4.
- [Release notes](https://github.com/ipfs/go-ipfs-files/releases)
- [Commits](https://github.com/ipfs/go-ipfs-files/compare/v0.0.2...v0.0.4)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

http: allow specifying a custom http client

fixes #174

http: cleanup http related errors

We don't need to return information about the actual HTTP error. That's usually
not something the user cares about (and is usually implied from the command).

This way, we get an actual context canceled error when the context is canceled.

fix: too many arguments error text

This doesn't mean we've picked the wrong command, we shouldn't try suggesting one.

fixes https://github.com/ipfs/go-ipfs/issues/6514

fallback executor support

This allows _trying_ to execute a command on a daemon, failing, and falling back
on another executor.

This is a breaking change and will affect Filecoin. However, filecoin is
currently using this incorrectly anyways (breaking PreRun and PostRun).

We _need_ to do this before calling PreRun but it's also nice to do this before
bothering the server.

make ErrorType a valid error and implement Unwrap on Error

That way, go 1.13's errors library can check if an error "is" one of these error
types.

feat: improve error codes

Fix a typo

* remove ErrNotFound - it isn't used. If we want to type not-found errors, we
  should consider adding a new error "subtype" field. All the current errors are
  effectively transport-level errors.
* remove ErrFatal - it's unclear how this should be handled.
* add ErrRateLimited - requested by @MichaelMure
* add ErrForbidden

fix: use golang's http.Error to send errors

This:

1. Ensures the correct content type.
2. Tells browsers not to sniff the content type.

This prevents any nasties from happening...

improve help text on narrow terminals

If the io.writer given to help text is the terminal, read its width. otherwise, use a default.

Otherwise, `ipfs daemon --help` and `ipfs p2p --help` look terrible.

We could be fancier and figure out the terminal width but wrapping at a fixed
80c is a decent start.

Instead of aligning flags in columns, display them right next to each other.
Otherwise, they take up *way* too much space.

chore: remove an old hack

http: use the request context

CloseNotifier has been deprecated for a while.

Also, ditch the "environment" context. We don't actually _need_ this.

merge in go-ipfs-cmdkit

Tested with go-ipfs and this doesn't seem necessary anymore.