GitLab

fix: normalize options when parsing them

We introduced a bug where we forgot to do this and couldn't find the definition
for the option.

This _also_ fixes (and tests) a bug where we'd allow duplicate flags in some
cases.

feat:add strings option; re-implement file ignore

- first step toward implementing file ignore

feat(file-ignore): implement file ignore

- add flags for providing a gitignore and/or list of files to ignore
- construct a filter to be passed to a SerialFile

feat(file-ignore): use go-ipfs-files fork; use renamed constructor

feat(file-ignore): test case w. ignore rules; refactor parseArgs

feat(file-ignore): ignore-rule opt is open-ended

- make ignore-rules options accept a path to a file
- add test case for ignore rules file

feat(file-ignore): help-text for variardic opts

- show StringsOption as variardic option in help-text
- add test case for variardic option

feat(file-ignore): rename rulesfile opt; fix typos

feat(file-ignore): temp replace of go-ipfs-files

- temporarily using go-ipfs-files fork until go-ipfs-files#26 is merged
- trying to get ci/cd builds working
- will revert before merging

feat(file-ignore): refactor cli/parse.go#setOpts

feat(file-ignore): cleanup parse.go; add test-case

feat(file-ignore): update ignore option copytext

feat(file-ignore): check opt against `optDef.Type`

- revert exclusion of options with `Strings` type,
so those option values are typechecked
- add command test cases

feat(file-ignore): add test-case w. hidden file

feat(file-ignore): build against go-ipfs-files@latest

feat(file-ignore): update go.mod/go.sum

Special-case accepting explicitly supplied named pipes

Chore/remove gx

build(deps): bump github.com/ipfs/go-ipfs-files from 0.0.4 to 0.0.6

Bumps [github.com/ipfs/go-ipfs-files](https://github.com/ipfs/go-ipfs-files) from 0.0.4 to 0.0.6.
- [Release notes](https://github.com/ipfs/go-ipfs-files/releases)
- [Commits](https://github.com/ipfs/go-ipfs-files/compare/v0.0.4...v0.0.6)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

build(deps): bump github.com/rs/cors from 1.6.0 to 1.7.0

Bumps [github.com/rs/cors](https://github.com/rs/cors) from 1.6.0 to 1.7.0.
- [Release notes](https://github.com/rs/cors/releases)
- [Commits](https://github.com/rs/cors/compare/v1.6.0...v1.7.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

build(deps): bump github.com/ipfs/go-ipfs-files from 0.0.2 to 0.0.4

Bumps [github.com/ipfs/go-ipfs-files](https://github.com/ipfs/go-ipfs-files) from 0.0.2 to 0.0.4.
- [Release notes](https://github.com/ipfs/go-ipfs-files/releases)
- [Commits](https://github.com/ipfs/go-ipfs-files/compare/v0.0.2...v0.0.4)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

http: allow specifying a custom http client

fixes #174

http: cleanup http related errors

We don't need to return information about the actual HTTP error. That's usually
not something the user cares about (and is usually implied from the command).

This way, we get an actual context canceled error when the context is canceled.

fix: too many arguments error text

This doesn't mean we've picked the wrong command, we shouldn't try suggesting one.

fixes https://github.com/ipfs/go-ipfs/issues/6514

fallback executor support

This allows _trying_ to execute a command on a daemon, failing, and falling back
on another executor.

This is a breaking change and will affect Filecoin. However, filecoin is
currently using this incorrectly anyways (breaking PreRun and PostRun).

We _need_ to do this before calling PreRun but it's also nice to do this before
bothering the server.

make ErrorType a valid error and implement Unwrap on Error

That way, go 1.13's errors library can check if an error "is" one of these error
types.

feat: improve error codes

Fix a typo

* remove ErrNotFound - it isn't used. If we want to type not-found errors, we
  should consider adding a new error "subtype" field. All the current errors are
  effectively transport-level errors.
* remove ErrFatal - it's unclear how this should be handled.
* add ErrRateLimited - requested by @MichaelMure
* add ErrForbidden

fix: use golang's http.Error to send errors