Skip to content

GitLab

Switch branch/tag
  1. 02 Dec, 2019 1 commit
  3. 20 Nov, 2019 1 commit
  5. 05 Mar, 2019 1 commit
  7. 18 Feb, 2019 1 commit
  9. 11 Sep, 2018 1 commit
  11. 15 Aug, 2018 1 commit
  13. 09 Aug, 2018 1 commit
  15. 12 Feb, 2017 1 commit
    • Jakub Sztandera's avatar
      make: rework makefiles for non-recursive make and add sharness coverage · 2d6a8b8e
      Jakub Sztandera authored 
      This commit introduces non-recursive Makefile infrastructure that replaces current Makefile infrastructure.
It also generally cleanups the Makefiles, separates them into nicer sub-modules and centralizes common operations into single definitions.

It allows to depend on any target that is defined in the makefile, this means that for example `gx install` is called once when `make build test_expensive_sharness` is called instead of 4 or 5 times.

It also makes the dependencies much cleaner and allows for reuse of modules. For example sharness coverage collection (WIP) uses sharness target with amended PATH, previously it might have been possible but not without wiring in the coverage collection into sharness make runner code.

Yes, it is more complex but not much more. There are few rules that have to be followed and few complexities added but IMHO it is worth it.

How to NR-make:
1. If make is to generate some file via a target, it MUST be defined in Rules.mk file in the directory of the target.
2. `Rules.mk` file MUST have `include mk/header.mk` statement as the first line and `include mk/footer.mk` statement as the last line (apart from project root `Rules.mk`).
3. It then MUST be included by the closest `Rules.mk` file up the directory tree.
4. Inside a `Rules.mk` special variable accessed as `$(d)` is defined. Its value is current directory, use it so if the `Rules.mk` file is moved in the tree it still works without a problem. Caution: this variable is not available in the recipe part and MUST NOT be used. Use name of the target or prerequisite to extract it if you need it.
5. Make has only one global scope, this means that name conflicts are a thing. Names SHOULD  follow `VAR_NAME_$(d)` convention. There are exceptions from this rule in form of well defined global variables. Examples: General lists `TGT_BIN`, `CLEAN`; General targets: `TEST`, `COVERAGE`; General variables: `GOFLAGS`, `DEPS_GO`.
3. Any rules, definitions or variables that fit some family SHOULD be defined in `mk/$family.mk` file and included from project root `Rules.mk`

License: MIT
Signed-off-by: default avatarJakub Sztandera <kubuxu@protonmail.ch>
      2d6a8b8e
  17. 13 Feb, 2016 1 commit
  19. 12 Jan, 2016 1 commit
    • Tommi Virtanen's avatar
      pin: Rewrite to store pins in IPFS objects · 8e0e03be
      Tommi Virtanen authored 
      WARNING: No migration performed! That needs to come in a separate
commit, perhaps amended into this one.

This is the minimal rewrite, only changing the storage from
JSON(+extra keys) in Datastore to IPFS objects. All of the pinning
state is still loaded in memory, and written from scratch on Flush. To
do more would require API changes, e.g. adding error returns.

Set/Multiset is not cleanly separated into a library, yet, as it's API
is expected to change radically.

License: MIT
Signed-off-by: default avatarJeromy <jeromyj@gmail.com>
      8e0e03be