notes

dht/handlers.go

@@ -86,7 +86,7 @@ func (dht *IpfsDHT) handleGetValue(p peer.Peer, pmes *Message) (*Message, error)
 		for _, p := range closer {
 			log.Debug("handleGetValue returning closer peer: '%s'", p)
 			if len(p.Addresses()) < 1 {
-				log.Error("no addresses on peer being sent!")
+				log.Critical("no addresses on peer being sent!")
 			}
 		}
 		resp.CloserPeers = peersToPBPeers(closer)

dht/query.go

@@ -232,6 +232,7 @@ func (r *dhtQueryRunner) queryPeer(p peer.Peer) {
 	}()
 
 	// make sure we're connected to the peer.
+	// (Incidentally, this will add it to the peerstore too)
 	err := r.query.dialer.DialPeer(p)
 	if err != nil {
 		log.Debug("ERROR worker for: %v -- err connecting: %v", p, err)