• Robert Carlsen's avatar
    fix panic where closenotify was called from wrong goroutine · ed23d99d
    Robert Carlsen authored
    Previously, this was the result when running a test with go1.6rc2:
    
        go test github.com/ipfs/go-ipfs/commands/http
        panic: net/http: CloseNotify called after ServeHTTP finished
    
        goroutine 19 [running]:
        net/http.(*response).CloseNotify(0xc8202ca1a0, 0x0)
            /home/r/go/src/net/http/server.go:1533 +0x9d
        github.com/ipfs/go-ipfs/commands/http.internalHandler.ServeHTTP.func2(0x7f42c9d1d180, 0xc8202ca1a0, 0x7f42c9d66e90, 0xc8200f0380, 0xc8201d40d0)
            /home/r/src/github.com/ipfs/go-ipfs/commands/http/handler.go:143 +0x39
        created by github.com/ipfs/go-ipfs/commands/http.internalHandler.ServeHTTP
            /home/r/src/github.com/ipfs/go-ipfs/commands/http/handler.go:147 +0x49d
        FAIL	github.com/ipfs/go-ipfs/commands/http	0.013s
    
    I had also encountered this panic when trying to use the webui.
    
    License: MIT
    Signed-off-by: default avatarRobert Carlsen <rwcarlsen@gmail.com>
    ed23d99d
handler.go 11.3 KB