Commit 2379aa0d authored by Steven Allen's avatar Steven Allen

update comment to note that we're punting on this

License: MIT
Signed-off-by: default avatarSteven Allen <steven@stebalien.com>
parent 87c69148
...@@ -139,7 +139,7 @@ func (s *blockService) AddBlock(o blocks.Block) error { ...@@ -139,7 +139,7 @@ func (s *blockService) AddBlock(o blocks.Block) error {
} }
if err := s.exchange.HasBlock(o); err != nil { if err := s.exchange.HasBlock(o); err != nil {
// TODO(stebalien): really an error? // TODO(#4623): really an error?
return errors.New("blockservice is closed") return errors.New("blockservice is closed")
} }
...@@ -170,7 +170,7 @@ func (s *blockService) AddBlocks(bs []blocks.Block) error { ...@@ -170,7 +170,7 @@ func (s *blockService) AddBlocks(bs []blocks.Block) error {
for _, o := range toput { for _, o := range toput {
if err := s.exchange.HasBlock(o); err != nil { if err := s.exchange.HasBlock(o); err != nil {
// TODO(stebalien): Should this really *return*? // TODO(#4623): Should this really *return*?
return fmt.Errorf("blockservice is closed (%s)", err) return fmt.Errorf("blockservice is closed (%s)", err)
} }
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment