Commit 5afa7ebf authored by chenminjian's avatar chenminjian

refact(cmd/repo): repo verify uses new cmd lib

License: MIT
Signed-off-by: default avatarchenminjian <727180553@qq.com>
parent f7b6ee3c
package commands package commands
import ( import (
"bytes"
"context" "context"
"errors" "errors"
"fmt" "fmt"
...@@ -13,8 +12,6 @@ import ( ...@@ -13,8 +12,6 @@ import (
"sync" "sync"
"text/tabwriter" "text/tabwriter"
oldcmds "github.com/ipfs/go-ipfs/commands"
lgc "github.com/ipfs/go-ipfs/commands/legacy"
cmdenv "github.com/ipfs/go-ipfs/core/commands/cmdenv" cmdenv "github.com/ipfs/go-ipfs/core/commands/cmdenv"
e "github.com/ipfs/go-ipfs/core/commands/e" e "github.com/ipfs/go-ipfs/core/commands/e"
corerepo "github.com/ipfs/go-ipfs/core/corerepo" corerepo "github.com/ipfs/go-ipfs/core/corerepo"
...@@ -44,7 +41,7 @@ var RepoCmd = &cmds.Command{ ...@@ -44,7 +41,7 @@ var RepoCmd = &cmds.Command{
"gc": repoGcCmd, "gc": repoGcCmd,
"fsck": RepoFsckCmd, "fsck": RepoFsckCmd,
"version": repoVersionCmd, "version": repoVersionCmd,
"verify": lgc.NewCommand(repoVerifyCmd), "verify": repoVerifyCmd,
}, },
} }
...@@ -323,91 +320,67 @@ func verifyResultChan(ctx context.Context, keys <-chan cid.Cid, bs bstore.Blocks ...@@ -323,91 +320,67 @@ func verifyResultChan(ctx context.Context, keys <-chan cid.Cid, bs bstore.Blocks
return results return results
} }
var repoVerifyCmd = &oldcmds.Command{ var repoVerifyCmd = &cmds.Command{
Helptext: cmdkit.HelpText{ Helptext: cmdkit.HelpText{
Tagline: "Verify all blocks in repo are not corrupted.", Tagline: "Verify all blocks in repo are not corrupted.",
}, },
Run: func(req oldcmds.Request, res oldcmds.Response) { Run: func(req *cmds.Request, res cmds.ResponseEmitter, env cmds.Environment) error {
nd, err := req.InvocContext().GetNode() nd, err := cmdenv.GetNode(env)
if err != nil { if err != nil {
res.SetError(err, cmdkit.ErrNormal) return err
return
} }
out := make(chan interface{})
res.SetOutput((<-chan interface{})(out))
defer close(out)
bs := bstore.NewBlockstore(nd.Repo.Datastore()) bs := bstore.NewBlockstore(nd.Repo.Datastore())
bs.HashOnRead(true) bs.HashOnRead(true)
keys, err := bs.AllKeysChan(req.Context()) keys, err := bs.AllKeysChan(req.Context)
if err != nil { if err != nil {
log.Error(err) log.Error(err)
return return err
} }
results := verifyResultChan(req.Context(), keys, bs) results := verifyResultChan(req.Context, keys, bs)
var fails int var fails int
var i int var i int
for msg := range results { for msg := range results {
if msg != "" { if msg != "" {
select { if err := res.Emit(&VerifyProgress{Msg: msg}); err != nil {
case out <- &VerifyProgress{Msg: msg}: return err
case <-req.Context().Done():
return
} }
fails++ fails++
} }
i++ i++
select { if err := res.Emit(&VerifyProgress{Progress: i}); err != nil {
case out <- &VerifyProgress{Progress: i}: return err
case <-req.Context().Done():
return
} }
} }
if fails == 0 { if fails != 0 {
select { return errors.New("verify complete, some blocks were corrupt")
case out <- &VerifyProgress{Msg: "verify complete, all blocks validated."}:
case <-req.Context().Done():
return
}
} else {
res.SetError(fmt.Errorf("verify complete, some blocks were corrupt"), cmdkit.ErrNormal)
} }
return res.Emit(&VerifyProgress{Msg: "verify complete, all blocks validated."})
}, },
Type: &VerifyProgress{}, Type: &VerifyProgress{},
Marshalers: oldcmds.MarshalerMap{ Encoders: cmds.EncoderMap{
oldcmds.Text: func(res oldcmds.Response) (io.Reader, error) { cmds.Text: cmds.MakeTypedEncoder(func(req *cmds.Request, w io.Writer, obj *VerifyProgress) error {
v, err := unwrapOutput(res.Output())
if err != nil {
return nil, err
}
obj, ok := v.(*VerifyProgress)
if !ok {
return nil, e.TypeErr(obj, v)
}
buf := new(bytes.Buffer)
if strings.Contains(obj.Msg, "was corrupt") { if strings.Contains(obj.Msg, "was corrupt") {
fmt.Fprintln(os.Stdout, obj.Msg) fmt.Fprintln(os.Stdout, obj.Msg)
return buf, nil return nil
} }
if obj.Msg != "" { if obj.Msg != "" {
if len(obj.Msg) < 20 { if len(obj.Msg) < 20 {
obj.Msg += " " obj.Msg += " "
} }
fmt.Fprintln(buf, obj.Msg) fmt.Fprintln(w, obj.Msg)
return buf, nil return nil
} }
fmt.Fprintf(buf, "%d blocks processed.\r", obj.Progress) fmt.Fprintf(w, "%d blocks processed.\r", obj.Progress)
return buf, nil return nil
}, }),
}, },
} }
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment