Commit e3255f46 authored by Jeromy's avatar Jeromy

address comments from CR

parent 3d80b9d2
......@@ -107,9 +107,15 @@ Publish an <ipfs-path> to another public key (not implemented):
}
func publish(n *core.IpfsNode, k crypto.PrivKey, ref path.Path) (*IpnsEntry, error) {
// First, verify the path exists
_, err := n.Resolver.ResolvePath(ref)
if err != nil {
return nil, err
}
pub := nsys.NewRoutingPublisher(n.Routing)
err := pub.Publish(n.Context(), k, ref)
err = pub.Publish(n.Context(), k, ref)
if err != nil {
return nil, err
}
......
......@@ -19,8 +19,8 @@ func IPNSHostnameOption() ServeOption {
defer cancel()
host := strings.SplitN(r.Host, ":", 2)[0]
if k, err := n.Namesys.Resolve(ctx, host); err == nil {
r.URL.Path = "/ipfs/" + k.String() + r.URL.Path
if p, err := n.Namesys.Resolve(ctx, host); err == nil {
r.URL.Path = "/ipfs/" + p.String() + r.URL.Path
}
childMux.ServeHTTP(w, r)
})
......
......@@ -49,11 +49,13 @@ func FromSegments(seg ...string) Path {
}
func ParsePath(txt string) (Path, error) {
kp, err := ParseKeyToPath(txt)
if err == nil {
return kp, nil
}
parts := strings.Split(txt, "/")
if len(parts) == 1 {
kp, err := ParseKeyToPath(txt)
if err == nil {
return kp, nil
}
}
if len(parts) < 3 {
return "", ErrBadPath
}
......@@ -66,7 +68,7 @@ func ParsePath(txt string) (Path, error) {
return "", ErrBadPath
}
_, err = ParseKeyToPath(parts[2])
_, err := ParseKeyToPath(parts[2])
if err != nil {
return "", err
}
......@@ -86,3 +88,8 @@ func ParseKeyToPath(txt string) (Path, error) {
}
return FromKey(u.Key(chk)), nil
}
func (p *Path) IsValid() error {
_, err := ParsePath(p.String())
return err
}
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment