GitLab

"for each desired change, make the change easy (warning: this may be
hard), then make the easy change" - Kent Beck

https://twitter.com/KentBeck/status/250733358307500032

http://martinfowler.com/articles/preparatory-refactoring-example.html

cc @jbenet @whyrusleeping

The struct was getting unmanageable. extracted the config component to
reduce complexity. The datastore will be written as another component.

fix(fsrepo): extract private, unsynced method to prevent deadlock

no issue detected but it's good to be safe

NB: daemon is one spot the repo lock is typically acquired

The pkg.Interface style is modeled after heap.Interface. Generally, I
find it helpful for interfaces that have many implementations. It
provides clear distinction between the generic interface and the |n|
implementations that implement it (which may be interface types
themselves).

For clients who cannot keep the repo name, one can imagine that the most
likely rename is `ipfsrepo`. In that case, `ipfsrepo.Interface` remains
meaningful.

This is low-pri so it doesn't matter than much. But for the record, the
repo.Interface feels appropriate in this use-case.

let me know if this looks off @whyrusleeping @jbenet