GitLab

![](http://m.memegen.com/77n7dk.jpg)

Important bugfix. Otherwise bitswap cannot message peers
the node has not connected to yet :(

new Service interface

Rather than pushing errors back down to lower layers, propagate the
errors upward.

This commit adds a `ReceiveError` method to BitSwap's network receiver.

Still TODO: rm the error return value from:

    net.service.handler.HandleMessage

This is inspired by delegation patterns in found in the wild.

style(exch:bitswap) rename NetMessage adapter impl

Move go-ipfs/bitswap package to go-ipfs/exchange/bitswap

* Delineates the difference between the generic exchange interface and
  implementations (eg. BitSwap protocol)

  Thus, the bitswap protocol can be refined without having to overthink
  how future exchanges will work. Aspects common to BitSwap and other
  exchanges can be extracted out to the exchange package in piecemeal.

  Future exchange implementations can be placed in sibling packages next
  to exchange/bitswap. (eg. exchange/multilateral)

makes more sense this way

@perfmode sender is exactly what we need to pass in to dht/bitswap.

We were issuing handling goroutines in both NewService and Start