GitLab

License: MIT
Signed-off-by: rht <rhtbot@gmail.com>

License: MIT
Signed-off-by: rht <rhtbot@gmail.com>

up until now there has been a very annoying bug with get, we would
get halting behavior. I'm not 100% sure this commit fixes it,
but it should. It certainly fixes others found in the process of
digging into the get / tar extractor code. (wish we could repro
the bug reliably enough to make a test case).

This is a much cleaner tar writer. the ad-hoc, error-prone synch
for the tar reader is gone (with i believe was incorrect). it is
replaced with a simple pipe and bufio. The tar logic is now in
tar.Writer, which writes unixfs dag nodes into a tar archive (no
need for synch here). And get's reader is constructed with DagArchive
which sets up the pipe + bufio.

NOTE: this commit also changes this behavior of `get`:
When retrieving a single file, if the file exists, get would fail.
this emulated the behavior of wget by default, which (without opts)
does not overwrite if the file is there. This change makes get
fail if the file is available locally. This seems more intuitive to
me as expected from a unix tool-- though perhaps it should be
discussed more before adopting.

Everything seems to work fine, and i have not been able to reproduce
the get halt bug.

License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>

License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>

License: MIT
Signed-off-by: Juan Batiz-Benet <juan@benet.ai>

License: MIT
Signed-off-by: rht <rhtbot@gmail.com>

To do that the current tests are move inside a
test_get_cmd() function. This function is then first
called before running the daemon for offline tests
and then after starting the daemon for online tests.

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>

cc @whyrusleeping: you werent doing so
cc @mappum: you were trying to escape them, but
   were un-escaping them in cases with longer quotes.

Let's use `>file`, not `> file`, as it makes it easier to parse.

@mappum these tests are failing (1 on osx and 1 on travis).
May be related to the versions of tar? not sure.