Skip to content

GitLab

Switch branch/tag
  1. 04 Apr, 2019 1 commit
  3. 13 Mar, 2019 1 commit
  5. 06 Mar, 2019 2 commits
  7. 05 Mar, 2019 6 commits
  9. 06 Nov, 2018 1 commit
  11. 09 Oct, 2018 1 commit
  13. 11 Sep, 2018 1 commit
  15. 19 Jul, 2018 1 commit
  17. 16 May, 2018 1 commit
  19. 23 Mar, 2018 2 commits
  21. 03 Feb, 2018 1 commit
  23. 16 Dec, 2017 1 commit
  25. 04 Dec, 2017 1 commit
  27. 01 Dec, 2017 1 commit
  29. 25 Aug, 2017 1 commit
  31. 22 Aug, 2017 1 commit
  33. 07 Jul, 2017 1 commit
  35. 01 Jun, 2017 1 commit
  37. 15 Mar, 2017 1 commit
  39. 11 Mar, 2017 1 commit
    • Lars Gierth's avatar
      make: fix build when symlinked into GOPATH · b54df01d
      Lars Gierth authored 
      In workspace setups that have the source tree symlinked into GOPATH,
the `go list `command wouldn't recognize that we're technically within GOPATH,
because `pwd` doesn't look like it.

For example

	/home/user/go/src/github.com/ipfs/go-ipfs
	=> /home/user/go/ipfs/go-ipfs

produces the import path

	_/home/user/ipfs/go-ipfs/Godeps/_workspace/src/github.com/jbenet/go-random/random

which is not within GOPATH.

We get around this by using fully-qualified import paths instead:
starting in github.com/ipfs/go-ipfs/ instead of ./

License: MIT
Signed-off-by: default avatarLars Gierth <larsg@systemli.org>
      b54df01d
  41. 12 Feb, 2017 3 commits
    • Jakub Sztandera's avatar
      mk/golang: fix multiple tags · 1a5c21cd
      Jakub Sztandera authored 
      License: MIT
Signed-off-by: default avatarJakub Sztandera <kubuxu@protonmail.ch>
      1a5c21cd
    • Jakub Sztandera's avatar
      Jenkins CI · 545f03e9
      Jakub Sztandera authored 
      License: MIT
Signed-off-by: default avatarJakub Sztandera <kubuxu@protonmail.ch>
      545f03e9
    • Jakub Sztandera's avatar
      make: rework makefiles for non-recursive make and add sharness coverage · f6302225
      Jakub Sztandera authored 
      This commit introduces non-recursive Makefile infrastructure that replaces current Makefile infrastructure.
It also generally cleanups the Makefiles, separates them into nicer sub-modules and centralizes common operations into single definitions.

It allows to depend on any target that is defined in the makefile, this means that for example `gx install` is called once when `make build test_expensive_sharness` is called instead of 4 or 5 times.

It also makes the dependencies much cleaner and allows for reuse of modules. For example sharness coverage collection (WIP) uses sharness target with amended PATH, previously it might have been possible but not without wiring in the coverage collection into sharness make runner code.

Yes, it is more complex but not much more. There are few rules that have to be followed and few complexities added but IMHO it is worth it.

How to NR-make:
1. If make is to generate some file via a target, it MUST be defined in Rules.mk file in the directory of the target.
2. `Rules.mk` file MUST have `include mk/header.mk` statement as the first line and `include mk/footer.mk` statement as the last line (apart from project root `Rules.mk`).
3. It then MUST be included by the closest `Rules.mk` file up the directory tree.
4. Inside a `Rules.mk` special variable accessed as `$(d)` is defined. Its value is current directory, use it so if the `Rules.mk` file is moved in the tree it still works without a problem. Caution: this variable is not available in the recipe part and MUST NOT be used. Use name of the target or prerequisite to extract it if you need it.
5. Make has only one global scope, this means that name conflicts are a thing. Names SHOULD  follow `VAR_NAME_$(d)` convention. There are exceptions from this rule in form of well defined global variables. Examples: General lists `TGT_BIN`, `CLEAN`; General targets: `TEST`, `COVERAGE`; General variables: `GOFLAGS`, `DEPS_GO`.
3. Any rules, definitions or variables that fit some family SHOULD be defined in `mk/$family.mk` file and included from project root `Rules.mk`

License: MIT
Signed-off-by: default avatarJakub Sztandera <kubuxu@protonmail.ch>
      f6302225