GitLab

All changes to date including pause requests & start paused, along with new adds for cleanups and checking of execution (#75)

* WIP

* feat(graphsync): pause/unpause requests

Allow graphsync requests to be paused and unpaused via request cancelling and DoNotSendCIDs
extension

* fix(requestmanager): refactor executor

remove extraneous allocation of closure functions

* feat(graphsync): support external request pauses

allow pausing requests imperatively via PauseRequest function

* fix(lint): fix lint errors

* feat(responsemanager): start requests paused

add the ability for a hook to pause a response right when it's first received

* feat(responsemanager): improve cancellation UX

provide a mechanism for responders to learn a requestor cancelled a request and for requestors to
learn a request was cancelled

* feat(requestmanager): process request cancelled status

process the responder returning a request cancelled error code and also support sentinel errors

* feat(executor): refactor to remove loader

remove loader, also only fire restart request as needed

* fix(asyncloader): load requests synchronously when possible

* fix(responsemanager): fix external pause

Fix external pauses missing a block

* fix(responsemanager): do not delay complete listener

Run complete listener in same thread as response processing, making it less susceptable to
interruption via cancel

* fix(responsemanager): fix context check

fix checking for context cancellation errors based off of the way ipld-prime does not wrap errors

* fix(responsemanager): more precise cancel

make cancels only get recorded if actual blocks are not sent -- otherwise the request is considered
complete -- and the complete hook always runs

* fix(requestmanager): handle non processed pauses

Handler the case where a pause is requested but never actually takes place

* refactor(responsemanager): handle cancels, correctly this time

Properly handle cancels for both paused and unpaused states

* fix(errors): remove regex cause it appears to be very slow

* fix(traverser): fix race condition for shutdown

make sure that the traverser is finished in the request executor

* fix(deps): mod tidy

* fix(executor): add back network error

* feat(responsemanager): add ability to pause response outside of a hook

Add the ability for anyone who knows a requestID & peer to pause a response at any time

* feat(responsemanager): add direct cancellations

add function to directly cancel responses from requestID. also, move query execution code to
seperate struct, internal for now

* fix(responsemanager): minor heap allocation optimization

* feat(responsemanager): support extensions on resume

Support sending extensions when resuming a request

* fix(lint): fix lint errors

Refactor request execution and use IPLD SkipMe functionality for proper partial results on a request (#70)

* refactor(requestmanager): refactor execution of requests

* feat(graphsync): properly use SkipMe from ipld to complete partial selections

* fix(requestmanager): remove unused function

Provides full implementation of do-no-send-cids on responder side

* feat(graphsync): add incoming block hook types

add types (not implemented) for incoming block hook

* feat(asyncloader): identify local loads

add a boolean value to AsyncLoadResult to determine if a request load was local

* fixup! feat(graphsync): add incoming block hook types

* feat(hooks): add block hooks plumbing

* feat(requestmanager): process block hooks

Process block hooks on each block, and connect last response to blocks

* feat(peerresponsemanager): add transactions

add the ability to do multple response operations with a gaurantee they will end up in a single
response

* refactor(lint): fix lint errors

* Updating go-ipld-prime to NodeAssembler era.

The 'testutil/chaintypes' codegen is currently dropped, and I ported
the testchain fixtures to using basicnode instead.  We can restore this
to using codegen soon, but it's easier to complete this set of changes
by temporarily switching to using basicnode.

Tests using 'NewUnencodableSelectorSpec' were discarded -- this more or
less exercised what would happen if an uninitialized zero value got
into a program, and this is now happily statically impossible.

Some tests are not passing; have not sussed yet.

* fix(deps): upgrade ipld-prime with bug fix

use ipld prime with fixed marshalling bug to get tests passing

* fix(lint): fix lint error
Co-authored-by: Eric Myhre <hash@exultant.us>

* feat(graphsync): add update to message

add update to message protobuf. also fix deserialization error with cancel requests

* feat(requestmanager): support updates for response hooks

Support sending request updates in incoming response hooks. Also factor hooks out of request manager

* refactor(hooks): make hooks approach consistent

for ease of use and learning in library, make hooks structure consistent across requestor and
responder

* feat(responsemanager): update request processing

Add the ability to processing update requests as needed

* test(responsemanager): add more tests for update behavior

* test(integration):add update integration test

Add test to verify the whole update flow

* fix(lint): fix lint error

* feat(deps): upgrade IPLD prime to last before refactor

* refactor(responsemanager): refactor traversal

switch to iterative traversal that is more amenable to interruption

* feat(peerresponsemanager): add bytes sent to peer response sender

Add a return value to SendResponse in peer response sender to return the number of block bytes
transmitted. Note: does not count unsent blocks. Also convert block size measurements to uint64

* feat(responsemanager): add response pausing

add first implementation of response pausing in response manager

* refactor(responsemanager): extract classes to simplify response manager

extract hooks as independant functionality

* test(responsemanager): add tests for block hooks and request hooks

* test(graphsync): add pause/resume integration test

* fix(responsemanager): fix directory misname

requesthooks.go directory -> requesthooks

* fix(tests): cleanup races & lint

* test(graphsync): fix flaky test

* feat(graphsync): define hook interfaces, test infrastructure

rename hooks, add outgoing request hook, define chain types for node builder chooser tests

* feat(graphsync): define persistence option

add persistence options to asyncloader & responsemanager + handling

* feat(graphsync): complete persistence / node builder chooser roundtrip

* fix(lint): fix lint errors

* refactor(hooks): refactor default validation as hook, add unregister option

* feat(graphsync): add disable default validation option

* fix(responsemanager): fix mutex  unlocking

cover case where unlocking was not happening

* refactor(tests): introduce testify

Introduce testify, cleanup lots of tests, add channel assertions to simplify channel tests, make
more readable

* refactor(tests): clean up error messages

* fix(deps): remove bitswap

remove accidentally added bitswap

* refactor(tests): put expected in correct position

Make sure for require.equal that the expected value is the first value

* ci(circle): switch to circle

Use configs from bitswap

* fix(deps): update and standardize

* fix(lint): fix lint errors

* fix(tests): relax timings for context cancels

Since we are not relying on context cancellation as anything but a test failsafe, relax timings
significantly for slower machines

* fix(test): fix minor test error

* fix(tests): minor timing fix

* fix(lint): fix lint errors

* fix(tests): relax timings for context cancels

Since we are not relying on context cancellation as anything but a test failsafe, relax timings

Remove all code references to a "bridge", consolodate test utils

remove remaining methods for ipld bridge

Removed mock selector spec, switch to using more real blockchain simulator

Remove the encode and decode on ipldbridge as part of ramp up to removing entirely
Also move selector encode/decode to within protobuf encoding

Incorporate go-ipld-prime-proto and write test to verify that graphsync works with it

DRY up integration test so it's more clear what each test is doing

Add processing of on extensions in responses in the request manager

define types and mock implementation for supporting extensions

refactor hook interface to pass an actions object

When the request manager receives extensions in a request, it processes them and returns their
response

define types and mock implementation for supporting extensions

add a default validation policy that only accepts selectors up to 100 depth

add the ability to send extensions when creating requests

To reduce future import cycles, and expose more types properly, move the root package to an
interface/types file and move the main implementation into /impl. This also exposes an interface
other implementers can replace.