GitLab

All changes to date including pause requests & start paused, along with new adds for cleanups and checking of execution (#75)

* WIP

* feat(graphsync): pause/unpause requests

Allow graphsync requests to be paused and unpaused via request cancelling and DoNotSendCIDs
extension

* fix(requestmanager): refactor executor

remove extraneous allocation of closure functions

* feat(graphsync): support external request pauses

allow pausing requests imperatively via PauseRequest function

* fix(lint): fix lint errors

* feat(responsemanager): start requests paused

add the ability for a hook to pause a response right when it's first received

* feat(responsemanager): improve cancellation UX

provide a mechanism for responders to learn a requestor cancelled a request and for requestors to
learn a request was cancelled

* feat(requestmanager): process request cancelled status

process the responder returning a request cancelled error code and also support sentinel errors

* feat(executor): refactor to remove loader

remove loader, also only fire restart request as needed

* fix(asyncloader): load requests synchronously when possible

* fix(responsemanager): fix external pause

Fix external pauses missing a block

* fix(responsemanager): do not delay complete listener

Run complete listener in same thread as response processing, making it less susceptable to
interruption via cancel

* fix(responsemanager): fix context check

fix checking for context cancellation errors based off of the way ipld-prime does not wrap errors

* fix(responsemanager): more precise cancel

make cancels only get recorded if actual blocks are not sent -- otherwise the request is considered
complete -- and the complete hook always runs

* fix(requestmanager): handle non processed pauses

Handler the case where a pause is requested but never actually takes place

* refactor(responsemanager): handle cancels, correctly this time

Properly handle cancels for both paused and unpaused states

* fix(errors): remove regex cause it appears to be very slow

* fix(traverser): fix race condition for shutdown

make sure that the traverser is finished in the request executor

* fix(deps): mod tidy

* fix(executor): add back network error

* Updating go-ipld-prime to NodeAssembler era.

The 'testutil/chaintypes' codegen is currently dropped, and I ported
the testchain fixtures to using basicnode instead.  We can restore this
to using codegen soon, but it's easier to complete this set of changes
by temporarily switching to using basicnode.

Tests using 'NewUnencodableSelectorSpec' were discarded -- this more or
less exercised what would happen if an uninitialized zero value got
into a program, and this is now happily statically impossible.

Some tests are not passing; have not sussed yet.

* fix(deps): upgrade ipld-prime with bug fix

use ipld prime with fixed marshalling bug to get tests passing

* fix(lint): fix lint error
Co-authored-by: Eric Myhre <hash@exultant.us>

* feat(graphsync): add update to message

add update to message protobuf. also fix deserialization error with cancel requests

* feat(requestmanager): support updates for response hooks

Support sending request updates in incoming response hooks. Also factor hooks out of request manager

* refactor(hooks): make hooks approach consistent

for ease of use and learning in library, make hooks structure consistent across requestor and
responder

* feat(responsemanager): update request processing

Add the ability to processing update requests as needed

* test(responsemanager): add more tests for update behavior

* test(integration):add update integration test

Add test to verify the whole update flow

* fix(lint): fix lint error

* refactor(tests): introduce testify

Introduce testify, cleanup lots of tests, add channel assertions to simplify channel tests, make
more readable

* refactor(tests): clean up error messages

* fix(deps): remove bitswap

remove accidentally added bitswap

* refactor(tests): put expected in correct position

Make sure for require.equal that the expected value is the first value

check for nil selector in a request and error if it is present

Remove all code references to a "bridge", consolodate test utils

Remove the encode and decode on ipldbridge as part of ramp up to removing entirely
Also move selector encode/decode to within protobuf encoding

To reduce future import cycles, and expose more types properly, move the root package to an
interface/types file and move the main implementation into /impl. This also exposes an interface
other implementers can replace.

return a boolean instead of an error if an extention is found on a message

Per https://github.com/ipld/specs/pull/205, metadata is now an extension, and further extensions
will be added soon

Adds callbacks to manage connections, also removes network receiver methods from public graphsync
interface, and updates libp2p to handle go-libp2p-core refactor

Updates IPLD Bridge to use latest go-ipld-prime and runs and actual round trip test using GraphSync,
go-ipld-prime, and real selectors

Convert GraphSyncRequest and GraphSyncResponse to structs, track by value, pass directly into add
methods on GraphSyncMessage

Create a manager for outgoing requests

Create a message queue to pool messages for a single peer and send them

Update to finalized protobuf format.
Also remove deprecated selector interface which is out of date

testutils will be general, so move them

correction to diagram, protobuff, and remove test function not needed

Add ToNet and FromNet functions that read/write to an io stream for use in network. Also type
response codes

Use a Cid as a root instead of a node, so that only one round trip is neccesary

Initial implementation of graph sync messages including protobuf struct and
serialization/deserialization

fix #2 fix #3