Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
10
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Open sidebar
dms3
go-ld-format
Commits
5837bec5
Commit
5837bec5
authored
Jun 26, 2017
by
Steven Allen
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
add/update comments about issues with DAGService interface
parent
26964053
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
6 additions
and
4 deletions
+6
-4
merkledag.go
merkledag.go
+6
-4
No files found.
merkledag.go
View file @
5837bec5
...
...
@@ -53,12 +53,14 @@ type DAGService interface {
NodeGetter
Add
(
Node
)
(
*
cid
.
Cid
,
error
)
// TODO(ipfs/go-ipfs#4010): Change this to take a CID.
// This will require a fair amount of refactoring.
Remove
(
Node
)
error
// TODO: This is returning them in-order?? Why not just use []NodePromise?
// Maybe add a couple of helpers for getting them in-order and as-available?
// GetDAG returns, in order, all the single leve child
// nodes of the passed in node.
// TODO: Consider using []NodePromise and providing helper functions
// that take []NodePromise and return channels that yield nodes both
// in-order and as-ready.
GetMany
(
context
.
Context
,
[]
*
cid
.
Cid
)
<-
chan
*
NodeOption
AddMany
([]
Node
)
([]
*
cid
.
Cid
,
error
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment