Commit 5837bec5 authored by Steven Allen's avatar Steven Allen

add/update comments about issues with DAGService interface

parent 26964053
......@@ -53,12 +53,14 @@ type DAGService interface {
NodeGetter
Add(Node) (*cid.Cid, error)
// TODO(ipfs/go-ipfs#4010): Change this to take a CID.
// This will require a fair amount of refactoring.
Remove(Node) error
// TODO: This is returning them in-order?? Why not just use []NodePromise?
// Maybe add a couple of helpers for getting them in-order and as-available?
// GetDAG returns, in order, all the single leve child
// nodes of the passed in node.
// TODO: Consider using []NodePromise and providing helper functions
// that take []NodePromise and return channels that yield nodes both
// in-order and as-ready.
GetMany(context.Context, []*cid.Cid) <-chan *NodeOption
AddMany([]Node) ([]*cid.Cid, error)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment