some bitswap cleanup

merkledag.go

@@ -28,7 +28,7 @@ type DAGService interface {
 	AddRecursive(*Node) error
 	Get(u.Key) (*Node, error)
 	Remove(*Node) error
-	BatchFetch(context.Context, *Node) <-chan *Node
+	GetKeysAsync(context.Context, *Node) <-chan *Node
 }
 
 func NewDAGService(bs *bserv.BlockService) DAGService {
@@ -298,41 +298,33 @@ func FindLink(n *Node, k u.Key, found []*Node) (int, error) {
 	return -1, u.ErrNotFound
 }
 
-// BatchFetch will fill out all of the links of the given Node.
+// GetKeysAsync will fill out all of the links of the given Node.
 // It returns a channel of nodes, which the caller can receive
 // all the child nodes of 'root' on, in proper order.
-func (ds *dagService) BatchFetch(ctx context.Context, root *Node) <-chan *Node {
+func (ds *dagService) GetKeysAsync(ctx context.Context, root *Node) <-chan *Node {
 	sig := make(chan *Node)
 	go func() {
 		var keys []u.Key
 		nodes := make([]*Node, len(root.Links))
 
-		//temp
-		recvd := []int{}
-		//
-
-		//
-		next := 0
-		//
-
 		for _, lnk := range root.Links {
 			keys = append(keys, u.Key(lnk.Hash))
 		}
 
 		blkchan := ds.Blocks.GetBlocks(ctx, keys)
 
-		count := 0
+		next := 0
 		for blk := range blkchan {
-			count++
 			i, err := FindLink(root, blk.Key(), nodes)
 			if err != nil {
+				// NB: can only occur as a result of programmer error
 				panic("Received block that wasnt in this nodes links!")
 			}
 
-			recvd = append(recvd, i)
-
 			nd, err := Decoded(blk.Data)
 			if err != nil {
+				// NB: can occur in normal situations, with improperly formatted
+				//		input data
 				log.Error("Got back bad block!")
 				break
 			}
@@ -347,23 +339,11 @@ func (ds *dagService) BatchFetch(ctx context.Context, root *Node) <-chan *Node {
 			}
 		}
 		if next < len(nodes) {
-			log.Errorf("count = %d, links = %d", count, len(nodes))
-			log.Error(recvd)
-			panic("didnt receive all requested blocks!")
+			// TODO: bubble errors back up.
+			log.Errorf("Did not receive correct number of nodes!")
 		}
 		close(sig)
 	}()
 
 	return sig
 }
-
-func checkForDupes(ks []u.Key) bool {
-	seen := make(map[u.Key]struct{})
-	for _, k := range ks {
-		if _, ok := seen[k]; ok {
-			return true
-		}
-		seen[k] = struct{}{}
-	}
-	return false
-}