Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
What's new
10
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Open sidebar
dms3
go-unixfs
Commits
5b5e17ed
Commit
5b5e17ed
authored
10 years ago
by
Brian Tiger Chow
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
style(bs:tx) rename receiver -> forwarder
parent
2edc03ac
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
14 additions
and
13 deletions
+14
-13
bitswap/bitswap.go
bitswap/bitswap.go
+1
-1
bitswap/transmission/forwarder.go
bitswap/transmission/forwarder.go
+6
-7
bitswap/transmission/forwarder_test.go
bitswap/transmission/forwarder_test.go
+5
-3
bitswap/transmission/interface.go
bitswap/transmission/interface.go
+1
-1
bitswap/transmission/service_wrapper.go
bitswap/transmission/service_wrapper.go
+1
-1
No files found.
bitswap/bitswap.go
View file @
5b5e17ed
...
...
@@ -64,7 +64,7 @@ type BitSwap struct {
// NewBitSwap creates a new BitSwap instance. It does not check its parameters.
func
NewBitSwap
(
p
*
peer
.
Peer
,
net
swarm
.
Network
,
d
ds
.
Datastore
,
r
routing
.
IpfsRouting
)
*
BitSwap
{
receiver
:=
receiv
er
{}
receiver
:=
tx
.
Forward
er
{}
sender
:=
tx
.
NewBSNetService
(
context
.
Background
(),
&
receiver
)
bs
:=
&
BitSwap
{
peer
:
p
,
...
...
This diff is collapsed.
Click to expand it.
bitswap/
receiv
er.go
→
bitswap/
transmission/forward
er.go
View file @
5b5e17ed
package
bitswap
package
transmission
import
(
context
"github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
bsmsg
"github.com/jbenet/go-ipfs/bitswap/message"
tx
"github.com/jbenet/go-ipfs/bitswap/transmission"
peer
"github.com/jbenet/go-ipfs/peer"
)
//
receiv
er breaks the circular dependency between bitswap and its sender
//
Forward
er breaks the circular dependency between bitswap and its sender
// NB: A sender is instantiated with a handler and this sender is then passed
// as a constructor argument to BitSwap. However, the handler is BitSwap!
// Hence, this receiver.
type
receiv
er
struct
{
delegate
tx
.
Receiver
type
Forward
er
struct
{
delegate
Receiver
}
func
(
r
*
receiv
er
)
ReceiveMessage
(
func
(
r
*
Forward
er
)
ReceiveMessage
(
ctx
context
.
Context
,
sender
*
peer
.
Peer
,
incoming
bsmsg
.
BitSwapMessage
)
(
bsmsg
.
BitSwapMessage
,
*
peer
.
Peer
,
error
)
{
if
r
.
delegate
==
nil
{
...
...
@@ -24,6 +23,6 @@ func (r *receiver) ReceiveMessage(
return
r
.
delegate
.
ReceiveMessage
(
ctx
,
sender
,
incoming
)
}
func
(
r
*
receiv
er
)
Delegate
(
delegate
tx
.
Receiver
)
{
func
(
r
*
Forward
er
)
Delegate
(
delegate
Receiver
)
{
r
.
delegate
=
delegate
}
This diff is collapsed.
Click to expand it.
bitswap/
receiv
er_test.go
→
bitswap/
transmission/forward
er_test.go
View file @
5b5e17ed
package
bitswap
package
transmission
import
(
"testing"
...
...
@@ -9,6 +9,8 @@ import (
)
func
TestDoesntPanicIfDelegateNotPresent
(
t
*
testing
.
T
)
{
r
:=
receiv
er
{}
r
.
ReceiveMessage
(
context
.
Background
(),
&
peer
.
Peer
{},
bsmsg
.
New
())
fwd
r
:=
Forward
er
{}
fwd
r
.
ReceiveMessage
(
context
.
Background
(),
&
peer
.
Peer
{},
bsmsg
.
New
())
}
// TODO(brian): func TestForwardsMessageToDelegate(t *testing.T)
This diff is collapsed.
Click to expand it.
bitswap/transmission/interface.go
View file @
5b5e17ed
package
network
package
transmission
import
(
context
"github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
...
...
This diff is collapsed.
Click to expand it.
bitswap/transmission/service_wrapper.go
View file @
5b5e17ed
package
network
package
transmission
import
(
context
"github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment