Commit 5b5e17ed authored by Brian Tiger Chow's avatar Brian Tiger Chow

style(bs:tx) rename receiver -> forwarder

parent 2edc03ac
......@@ -64,7 +64,7 @@ type BitSwap struct {
// NewBitSwap creates a new BitSwap instance. It does not check its parameters.
func NewBitSwap(p *peer.Peer, net swarm.Network, d ds.Datastore, r routing.IpfsRouting) *BitSwap {
receiver := receiver{}
receiver := tx.Forwarder{}
sender := tx.NewBSNetService(context.Background(), &receiver)
bs := &BitSwap{
peer: p,
......
package bitswap
package transmission
import (
context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
bsmsg "github.com/jbenet/go-ipfs/bitswap/message"
tx "github.com/jbenet/go-ipfs/bitswap/transmission"
peer "github.com/jbenet/go-ipfs/peer"
)
// receiver breaks the circular dependency between bitswap and its sender
// Forwarder breaks the circular dependency between bitswap and its sender
// NB: A sender is instantiated with a handler and this sender is then passed
// as a constructor argument to BitSwap. However, the handler is BitSwap!
// Hence, this receiver.
type receiver struct {
delegate tx.Receiver
type Forwarder struct {
delegate Receiver
}
func (r *receiver) ReceiveMessage(
func (r *Forwarder) ReceiveMessage(
ctx context.Context, sender *peer.Peer, incoming bsmsg.BitSwapMessage) (
bsmsg.BitSwapMessage, *peer.Peer, error) {
if r.delegate == nil {
......@@ -24,6 +23,6 @@ func (r *receiver) ReceiveMessage(
return r.delegate.ReceiveMessage(ctx, sender, incoming)
}
func (r *receiver) Delegate(delegate tx.Receiver) {
func (r *Forwarder) Delegate(delegate Receiver) {
r.delegate = delegate
}
package bitswap
package transmission
import (
"testing"
......@@ -9,6 +9,8 @@ import (
)
func TestDoesntPanicIfDelegateNotPresent(t *testing.T) {
r := receiver{}
r.ReceiveMessage(context.Background(), &peer.Peer{}, bsmsg.New())
fwdr := Forwarder{}
fwdr.ReceiveMessage(context.Background(), &peer.Peer{}, bsmsg.New())
}
// TODO(brian): func TestForwardsMessageToDelegate(t *testing.T)
package network
package transmission
import (
context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
......
package network
package transmission
import (
context "github.com/jbenet/go-ipfs/Godeps/_workspace/src/code.google.com/p/go.net/context"
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment