fix security comment #92

d17fcc17 · Juan Batiz-Benet · Brian Tiger Chow · aa296039 · d17fcc17 · d17fcc17
Commit d17fcc17 authored Sep 19, 2014 by Juan Batiz-Benet Committed by Brian Tiger Chow Sep 22, 2014
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

cmd/ipfs/init.go cmd/ipfs/init.go +2 -1

config/config.go config/config.go +2 -1

No files found.
--- a/cmd/ipfs/init.go
+++ b/cmd/ipfs/init.go
@@ -83,7 +83,8 @@ func initCmd(c *commander.Command, inp []string) error {
 		return err
 	}

-	// pretend to encrypt key, then store it unencrypted
+	// currently storing key unencrypted. in the future we need to encrypt it.
+	// TODO(security)
 	skbytes, err := sk.Bytes()
 	if err != nil {
 		return err

--- a/config/config.go
+++ b/config/config.go
@@ -52,7 +52,8 @@ func (i *Identity) DecodePrivateKey(passphrase string) (crypto.PrivateKey, error
 		return nil, err
 	}

-	//pretend to actually decrypt private key
+	// currently storing key unencrypted. in the future we need to encrypt it.
+	// TODO(security)
 	return x509.ParsePKCS1PrivateKey(pkb)
 }