Commits · bd3ee739b92d9a3740ee81e2a4eaad9eb22fafa8 · dms3 / go-unixfs

18 Dec, 2014 28 commits

doc: some comments about the future of the decision engine · bd3ee739
Brian Tiger Chow authored Dec 17, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
bd3ee739
refactor(bs/decision.Engine): pass in Entry · 175513e2
Brian Tiger Chow authored Dec 17, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
175513e2
extract constants · 4bcfe094
Brian Tiger Chow authored Dec 17, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
4bcfe094
log unusual event · e36d6566
Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
e36d6566

fix: check blockstore before adding task · 2b60b641

Brian Tiger Chow authored Dec 16, 2014

addresses https://github.com/jbenet/go-ipfs/pull/438#discussion_r21953742

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

2b60b641

unexport functions · 6e7c46a6
Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
6e7c46a6
rm unused method · 1b1260b6
Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
1b1260b6

rename to peerRequestQueue · acc71482

Brian Tiger Chow authored Dec 16, 2014

this opens up the possibility of having multiple queues. And for all
outgoing messages to be managed by the decision engine

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

acc71482

rename to strategy.LedgerManager to decision.Engine · 5bd0b954
Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
5bd0b954

refactor: put mutex next to the things it protects · d069ae11

Brian Tiger Chow authored Dec 16, 2014

If we put the lock next to the fields it protects, it can sometimes make
it easier to reason about threadsafety.

In this case, it reveals that the task queue (not threadsafe) isn't protected by the
mutex, yet shared between the worker and callers.

@whyrusleeping

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

d069ae11

refactor: remove ledgerMap type · 962a9477

Brian Tiger Chow authored Dec 16, 2014

it's only used in two places, but i think we've been using maps on IPFS
types so much now that the specificity is no longer necessary

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

962a9477

refactor: re-use wantlist.Entry type wherever it makes sense · fedcebf6

Brian Tiger Chow authored Dec 16, 2014

it seems to make sense since, in each place, the Key and Priority
represent the same information

b/c you know the saying...

"It is better to have 100 functions operate on one data structure than
10 functions on 10 data structures."

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

fedcebf6

doc: add comment to Envelope · 1d715956
Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
1d715956
tq.Cancel -> tq.Remove · 181ff4ea
Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
181ff4ea
it's not a queue yet but it's okay to name it as such · 198aa195
Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
198aa195
perf: avoid lots of communication by signaling once at end of method · 7280aac8
Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
7280aac8
add comment to fix race · cc2a7312
Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
cc2a7312

refactor: remove peerKey type · b41fef2f

Brian Tiger Chow authored Dec 16, 2014

we've been using maps with peers long enough now that this probably is
no longer necessary

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

b41fef2f

unexport task and taskList · 286723d8

Brian Tiger Chow authored Dec 16, 2014

the less bitswap has to know about, the easier it'll be for readers.
(This now returns Messages.)

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

286723d8

refactor: taskKey := p.Key() + block.Key() · 93fde86d

Brian Tiger Chow authored Dec 16, 2014

for clarity and to avoid errors, define a function

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

93fde86d

refactor: context first in argument list · 10e970c0
Brian Tiger Chow authored Dec 16, 2014
```
(merely by convention)

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
10e970c0

refactor: change Tasks to Outbox · 2ea8ed81

Brian Tiger Chow authored Dec 16, 2014

notice that moving the blockstore fetch into the manager removes the
weird error handling case.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

2ea8ed81

avoid attaching context to object when it's not necessary. · f5336787
Brian Tiger Chow authored Dec 15, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
f5336787
name findOrCreate · f028c44f
Brian Tiger Chow authored Dec 15, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
f028c44f
queue-like naming · 1bced710
Brian Tiger Chow authored Dec 15, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
1bced710
renaming and removing empty strategy file · 90a30961
Jeromy authored Dec 16, 2014

90a30961
tasklist queue for bitswap tasks · 029e305f
Jeromy authored Dec 16, 2014

029e305f
extracted ledgerset from strategy, cleaned up a few comments from the PR · 57e7dd7b
Jeromy authored Dec 10, 2014

57e7dd7b