Skip to content

GitLab

Switch branch/tag
  1. 06 Jul, 2018 1 commit
    • Lucas Molas's avatar
      pbdagreader: use FSNode instead of protobuf structure · c847ff39
      Lucas Molas authored 
      Focus on the UnixFS layer and avoid explicit references to protocol buffers
format (used to serialize objects of that layer). Use the `unixfs.FSNode`
structure which it abstracts from the `unixfs.pb.Data` format.

Replace `PBDagReader` field `ftpb.Data` with `ft.FSNode`, renaming it to `file`
(which is the type of UnixFS object represented in the reader) and changing its
comment removing the "cached" reference, as this structure is not used here as a
cache (`PBDagReader` doesn't modify the DAG, it's read-only). Also, removed
unused `ProtoNode` field to avoid confusions, as it would normally be present if
the `FSNode` was in fact used as a cache of the contents of the `ProtoNode`.

An example of the advantage of shifting the focus from the format to the UnixFS
layer is dropping the of use `len(pb.Blocksizes)` in favor of the more clear
`NumChildren()` abstraction.

Added `BlockSize()` accessor.

License: MIT
Signed-off-by: default avatarLucas Molas <schomatis@gmail.com>
      c847ff39
  3. 09 Jun, 2018 1 commit
  5. 19 Apr, 2018 1 commit
  7. 17 Apr, 2018 1 commit
    • Lucas Molas's avatar
      dag: deduplicate AddNodeLinkClean into AddNodeLink · 165433d2
      Lucas Molas authored 
      `AddNodeLink` used to cache the linked node whereas `AddNodeLinkClean`
did not, however, at some point the former was changed to do the same
thing as the latter (i.e., not cache the linked node). That is, they now
do the same thing so there's no reason to have both.

The name `AddNodeLink` is preserved, even though it used to imply the
cache functionality contrasting with the `Clean` suffix of
`AddNodeLinkClean`, with this function removed the cache connotation
doesn't hold anymore.

License: MIT
Signed-off-by: default avatarLucas Molas <schomatis@gmail.com>
      165433d2
  9. 30 Mar, 2018 1 commit
  11. 23 Mar, 2018 3 commits
  13. 15 Mar, 2018 1 commit
  15. 07 Feb, 2018 2 commits
  17. 06 Feb, 2018 3 commits
  19. 02 Feb, 2018 1 commit
  21. 29 Jan, 2018 1 commit
  23. 25 Jan, 2018 2 commits
  25. 24 Jan, 2018 1 commit
  27. 02 Jan, 2018 1 commit
  29. 31 Dec, 2017 1 commit
  31. 14 Dec, 2017 1 commit
  33. 19 Oct, 2017 4 commits
  35. 18 Oct, 2017 2 commits
  37. 02 Sep, 2017 1 commit
  39. 12 Jul, 2017 1 commit
  41. 04 Jul, 2017 1 commit
  43. 29 Jun, 2017 1 commit
  45. 31 May, 2017 1 commit
  47. 01 May, 2017 1 commit
  49. 30 Apr, 2017 1 commit
  51. 29 Apr, 2017 1 commit
  53. 26 Apr, 2017 3 commits
  55. 20 Apr, 2017 1 commit