• Eric Myhre's avatar
    Revert "Make the cidlink.Link type only usable as a pointer." · 96aa55ea
    Eric Myhre authored
    Trying to make CIDs only usable as a pointer would be nice from a
    consistency perspective, but has other consequences.
    
    It's easy to forget this (and I apparently just did), but...
    We often use link types as map keys.  And this is Important.
    
    That means trying to handle CIDs as pointers leads to nonsensical
    results: pointers are technically valid as a golang map key, but
    they don't "do the right thing" -- the equality check ends up operating
    on the the pointer rather than on the data.  This is well-defined,
    but generally useless for these types in context.
    96aa55ea
unmarshal.go 6.58 KB