Move error assertion outside of for loop

7ab5731c · Yulin Chen · 003cc812 · 7ab5731c
Commit 7ab5731c authored Aug 30, 2017 by Yulin Chen
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

cidranger_test.go cidranger_test.go +2 -2

No files found.
--- a/cidranger_test.go
+++ b/cidranger_test.go
@@ -48,8 +48,8 @@ func testContainsAgainstBase(t *testing.T, iterations int, ipGen ipGenerator) {
 	for i := 0; i < iterations; i++ {
 		nn := ipGen()
 		expected, err := baseRanger.Contains(nn.ToIP())
+		assert.NoError(t, err)
 		for _, ranger := range rangers {
-			assert.NoError(t, err)
 			actual, err := ranger.Contains(nn.ToIP())
 			assert.NoError(t, err)
 			assert.Equal(t, expected, actual)
@@ -68,8 +68,8 @@ func testContainingNetworksAgainstBase(t *testing.T, iterations int, ipGen ipGen
 	for i := 0; i < iterations; i++ {
 		nn := ipGen()
 		expected, err := baseRanger.ContainingNetworks(nn.ToIP())
+		assert.NoError(t, err)
 		for _, ranger := range rangers {
-			assert.NoError(t, err)
 			actual, err := ranger.ContainingNetworks(nn.ToIP())
 			assert.NoError(t, err)
 			assert.Equal(t, len(expected), len(actual))