dht_test.go 31.5 KB
Newer Older
1 2
package dht

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
3
import (
4
	"bytes"
Jeromy's avatar
Jeromy committed
5
	"context"
6
	"errors"
7
	"fmt"
Matt Joiner's avatar
Matt Joiner committed
8 9
	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"
10
	"math/rand"
11
	"sort"
12
	"strings"
13
	"sync"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
14
	"testing"
15
	"time"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
16

17 18
	opts "github.com/libp2p/go-libp2p-kad-dht/v5/opts"
	pb "github.com/libp2p/go-libp2p-kad-dht/v5/pb"
19

20
	cid "github.com/ipfs/go-cid"
21
	u "github.com/ipfs/go-ipfs-util"
22
	kb "github.com/libp2p/go-libp2p-kbucket"
23 24
	peer "github.com/libp2p/go-libp2p-peer"
	pstore "github.com/libp2p/go-libp2p-peerstore"
George Antoniadis's avatar
George Antoniadis committed
25
	record "github.com/libp2p/go-libp2p-record"
26
	routing "github.com/libp2p/go-libp2p-routing"
Steven Allen's avatar
Steven Allen committed
27
	swarmt "github.com/libp2p/go-libp2p-swarm/testing"
Jeromy's avatar
Jeromy committed
28
	bhost "github.com/libp2p/go-libp2p/p2p/host/basic"
George Antoniadis's avatar
George Antoniadis committed
29 30
	ci "github.com/libp2p/go-testutil/ci"
	travisci "github.com/libp2p/go-testutil/ci/travis"
31
	ma "github.com/multiformats/go-multiaddr"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
32 33
)

34
var testCaseValues = map[string][]byte{}
35
var testCaseCids []cid.Cid
36 37 38 39

func init() {
	for i := 0; i < 100; i++ {
		v := fmt.Sprintf("%d -- value", i)
40 41 42

		mhv := u.Hash([]byte(v))
		testCaseCids = append(testCaseCids, cid.NewCidV0(mhv))
43 44 45
	}
}

46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75
type blankValidator struct{}

func (blankValidator) Validate(_ string, _ []byte) error        { return nil }
func (blankValidator) Select(_ string, _ [][]byte) (int, error) { return 0, nil }

type testValidator struct{}

func (testValidator) Select(_ string, bs [][]byte) (int, error) {
	index := -1
	for i, b := range bs {
		if bytes.Compare(b, []byte("newer")) == 0 {
			index = i
		} else if bytes.Compare(b, []byte("valid")) == 0 {
			if index == -1 {
				index = i
			}
		}
	}
	if index == -1 {
		return -1, errors.New("no rec found")
	}
	return index, nil
}
func (testValidator) Validate(_ string, b []byte) error {
	if bytes.Compare(b, []byte("expired")) == 0 {
		return errors.New("expired")
	}
	return nil
}

76
func setupDHT(ctx context.Context, t *testing.T, client bool) *IpfsDHT {
77 78
	d, err := New(
		ctx,
Steven Allen's avatar
Steven Allen committed
79
		bhost.New(swarmt.GenSwarm(t, ctx, swarmt.OptDisableReuseport)),
80 81 82
		opts.Client(client),
		opts.NamespacedValidator("v", blankValidator{}),
	)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
83

84 85
	if err != nil {
		t.Fatal(err)
86
	}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
87 88 89
	return d
}

90 91
func setupDHTS(ctx context.Context, n int, t *testing.T) ([]ma.Multiaddr, []peer.ID, []*IpfsDHT) {
	addrs := make([]ma.Multiaddr, n)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
92
	dhts := make([]*IpfsDHT, n)
93 94
	peers := make([]peer.ID, n)

95 96 97
	sanityAddrsMap := make(map[string]struct{})
	sanityPeersMap := make(map[string]struct{})

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
98
	for i := 0; i < n; i++ {
99
		dhts[i] = setupDHT(ctx, t, false)
100
		peers[i] = dhts[i].self
101
		addrs[i] = dhts[i].peerstore.Addrs(dhts[i].self)[0]
102 103

		if _, lol := sanityAddrsMap[addrs[i].String()]; lol {
Jakub Sztandera's avatar
Jakub Sztandera committed
104
			t.Fatal("While setting up DHTs address got duplicated.")
105 106 107 108
		} else {
			sanityAddrsMap[addrs[i].String()] = struct{}{}
		}
		if _, lol := sanityPeersMap[peers[i].String()]; lol {
Jakub Sztandera's avatar
Jakub Sztandera committed
109
			t.Fatal("While setting up DHTs peerid got duplicated.")
110 111 112
		} else {
			sanityPeersMap[peers[i].String()] = struct{}{}
		}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
113 114 115 116 117
	}

	return addrs, peers, dhts
}

118
func connectNoSync(t *testing.T, ctx context.Context, a, b *IpfsDHT) {
119 120
	t.Helper()

121
	idB := b.self
122
	addrB := b.peerstore.Addrs(idB)
123 124
	if len(addrB) == 0 {
		t.Fatal("peers setup incorrectly: no local address")
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
125
	}
126

Jeromy's avatar
Jeromy committed
127 128
	a.peerstore.AddAddrs(idB, addrB, pstore.TempAddrTTL)
	pi := pstore.PeerInfo{ID: idB}
Jeromy's avatar
Jeromy committed
129
	if err := a.host.Connect(ctx, pi); err != nil {
130
		t.Fatal(err)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
131
	}
132 133
}

134 135
func wait(t *testing.T, ctx context.Context, a, b *IpfsDHT) {
	t.Helper()
136

137 138
	// loop until connection notification has been received.
	// under high load, this may not happen as immediately as we would like.
139
	for a.routingTable.Find(b.self) == "" {
140 141 142 143 144
		select {
		case <-ctx.Done():
			t.Fatal(ctx.Err())
		case <-time.After(time.Millisecond * 5):
		}
145
	}
146
}
147

148 149 150 151 152
func connect(t *testing.T, ctx context.Context, a, b *IpfsDHT) {
	t.Helper()
	connectNoSync(t, ctx, a, b)
	wait(t, ctx, a, b)
	wait(t, ctx, b, a)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
153 154
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
155
func bootstrap(t *testing.T, ctx context.Context, dhts []*IpfsDHT) {
156

157
	ctx, cancel := context.WithCancel(ctx)
Steven Allen's avatar
Steven Allen committed
158 159
	defer cancel()

Matt Joiner's avatar
Matt Joiner committed
160
	logger.Debugf("Bootstrapping DHTs...")
161 162 163 164 165 166

	// tried async. sequential fares much better. compare:
	// 100 async https://gist.github.com/jbenet/56d12f0578d5f34810b2
	// 100 sync https://gist.github.com/jbenet/6c59e7c15426e48aaedd
	// probably because results compound

167 168 169 170
	var cfg BootstrapConfig
	cfg = DefaultBootstrapConfig
	cfg.Queries = 3

171 172 173
	start := rand.Intn(len(dhts)) // randomize to decrease bias.
	for i := range dhts {
		dht := dhts[(start+i)%len(dhts)]
174
		dht.runBootstrap(ctx, cfg)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
175 176 177
	}
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
178
func TestValueGetSet(t *testing.T) {
179 180
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
181

Steven Allen's avatar
Steven Allen committed
182
	var dhts [5]*IpfsDHT
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
183

Steven Allen's avatar
Steven Allen committed
184 185 186 187 188
	for i := range dhts {
		dhts[i] = setupDHT(ctx, t, false)
		defer dhts[i].Close()
		defer dhts[i].host.Close()
	}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
189

Steven Allen's avatar
Steven Allen committed
190
	connect(t, ctx, dhts[0], dhts[1])
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
191

Steven Allen's avatar
Steven Allen committed
192
	t.Log("adding value on: ", dhts[0].self)
Jeromy's avatar
Jeromy committed
193 194
	ctxT, cancel := context.WithTimeout(ctx, time.Second)
	defer cancel()
Steven Allen's avatar
Steven Allen committed
195
	err := dhts[0].PutValue(ctxT, "/v/hello", []byte("world"))
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
196 197 198 199
	if err != nil {
		t.Fatal(err)
	}

Steven Allen's avatar
Steven Allen committed
200
	t.Log("requesting value on dhts: ", dhts[1].self)
Jeromy's avatar
Jeromy committed
201 202
	ctxT, cancel = context.WithTimeout(ctx, time.Second*2)
	defer cancel()
Steven Allen's avatar
Steven Allen committed
203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243

	val, err := dhts[1].GetValue(ctxT, "/v/hello")
	if err != nil {
		t.Fatal(err)
	}

	if string(val) != "world" {
		t.Fatalf("Expected 'world' got '%s'", string(val))
	}

	// late connect

	connect(t, ctx, dhts[2], dhts[0])
	connect(t, ctx, dhts[2], dhts[1])

	t.Log("requesting value (offline) on dhts: ", dhts[2].self)
	vala, err := dhts[2].GetValue(ctxT, "/v/hello", Quorum(0))
	if vala != nil {
		t.Fatalf("offline get should have failed, got %s", string(vala))
	}
	if err != routing.ErrNotFound {
		t.Fatalf("offline get should have failed with ErrNotFound, got: %s", err)
	}

	t.Log("requesting value (online) on dhts: ", dhts[2].self)
	val, err = dhts[2].GetValue(ctxT, "/v/hello")
	if err != nil {
		t.Fatal(err)
	}

	if string(val) != "world" {
		t.Fatalf("Expected 'world' got '%s'", string(val))
	}

	for _, d := range dhts[:3] {
		connect(t, ctx, dhts[3], d)
	}
	connect(t, ctx, dhts[4], dhts[3])

	t.Log("requesting value (requires peer routing) on dhts: ", dhts[4].self)
	val, err = dhts[4].GetValue(ctxT, "/v/hello")
244 245 246 247
	if err != nil {
		t.Fatal(err)
	}

Steven Allen's avatar
Steven Allen committed
248 249
	if string(val) != "world" {
		t.Fatalf("Expected 'world' got '%s'", string(val))
250
	}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
251 252
}

253 254 255 256 257 258 259 260 261 262 263 264
func TestValueSetInvalid(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	dhtA := setupDHT(ctx, t, false)
	dhtB := setupDHT(ctx, t, false)

	defer dhtA.Close()
	defer dhtB.Close()
	defer dhtA.host.Close()
	defer dhtB.host.Close()

265
	dhtA.Validator.(record.NamespacedValidator)["v"] = testValidator{}
266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305
	dhtB.Validator.(record.NamespacedValidator)["v"] = blankValidator{}

	connect(t, ctx, dhtA, dhtB)

	testSetGet := func(val string, failset bool, exp string, experr error) {
		t.Helper()

		ctxT, cancel := context.WithTimeout(ctx, time.Second)
		defer cancel()
		err := dhtA.PutValue(ctxT, "/v/hello", []byte(val))
		if failset {
			if err == nil {
				t.Error("expected set to fail")
			}
		} else {
			if err != nil {
				t.Error(err)
			}
		}

		ctxT, cancel = context.WithTimeout(ctx, time.Second*2)
		defer cancel()
		valb, err := dhtB.GetValue(ctxT, "/v/hello")
		if err != experr {
			t.Errorf("Set/Get %v: Expected %v error but got %v", val, experr, err)
		} else if err == nil && string(valb) != exp {
			t.Errorf("Expected '%v' got '%s'", exp, string(valb))
		}
	}

	// Expired records should not be set
	testSetGet("expired", true, "", routing.ErrNotFound)
	// Valid record should be returned
	testSetGet("valid", false, "valid", nil)
	// Newer record should supersede previous record
	testSetGet("newer", false, "newer", nil)
	// Attempt to set older record again should be ignored
	testSetGet("valid", true, "newer", nil)
}

Łukasz Magiera's avatar
Łukasz Magiera committed
306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332
func TestSearchValue(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	dhtA := setupDHT(ctx, t, false)
	dhtB := setupDHT(ctx, t, false)

	defer dhtA.Close()
	defer dhtB.Close()
	defer dhtA.host.Close()
	defer dhtB.host.Close()

	connect(t, ctx, dhtA, dhtB)

	dhtA.Validator.(record.NamespacedValidator)["v"] = testValidator{}
	dhtB.Validator.(record.NamespacedValidator)["v"] = testValidator{}

	ctxT, cancel := context.WithTimeout(ctx, time.Second)
	defer cancel()

	err := dhtA.PutValue(ctxT, "/v/hello", []byte("valid"))
	if err != nil {
		t.Error(err)
	}

	ctxT, cancel = context.WithTimeout(ctx, time.Second*2)
	defer cancel()
333
	valCh, err := dhtA.SearchValue(ctxT, "/v/hello", Quorum(-1))
334 335 336
	if err != nil {
		t.Fatal(err)
	}
Łukasz Magiera's avatar
Łukasz Magiera committed
337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361

	select {
	case v := <-valCh:
		if string(v) != "valid" {
			t.Errorf("expected 'valid', got '%s'", string(v))
		}
	case <-ctxT.Done():
		t.Fatal(ctxT.Err())
	}

	err = dhtB.PutValue(ctxT, "/v/hello", []byte("newer"))
	if err != nil {
		t.Error(err)
	}

	select {
	case v := <-valCh:
		if string(v) != "newer" {
			t.Errorf("expected 'newer', got '%s'", string(v))
		}
	case <-ctxT.Done():
		t.Fatal(ctxT.Err())
	}
}

362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399
func TestGetValues(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	dhtA := setupDHT(ctx, t, false)
	dhtB := setupDHT(ctx, t, false)

	defer dhtA.Close()
	defer dhtB.Close()
	defer dhtA.host.Close()
	defer dhtB.host.Close()

	connect(t, ctx, dhtA, dhtB)

	ctxT, cancel := context.WithTimeout(ctx, time.Second)
	defer cancel()

	err := dhtB.PutValue(ctxT, "/v/hello", []byte("newer"))
	if err != nil {
		t.Error(err)
	}

	err = dhtA.PutValue(ctxT, "/v/hello", []byte("valid"))
	if err != nil {
		t.Error(err)
	}

	ctxT, cancel = context.WithTimeout(ctx, time.Second*2)
	defer cancel()
	vals, err := dhtA.GetValues(ctxT, "/v/hello", 16)
	if err != nil {
		t.Fatal(err)
	}

	if len(vals) != 2 {
		t.Fatalf("expected to get 2 values, got %d", len(vals))
	}

400
	sort.Slice(vals, func(i, j int) bool { return string(vals[i].Val) < string(vals[j].Val) })
401 402 403 404 405 406 407 408 409

	if string(vals[0].Val) != "valid" {
		t.Errorf("unexpected vals[0]: %s", string(vals[0].Val))
	}
	if string(vals[1].Val) != "valid" {
		t.Errorf("unexpected vals[1]: %s", string(vals[1].Val))
	}
}

410 411 412 413 414 415 416 417 418 419 420 421 422
func TestValueGetInvalid(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	dhtA := setupDHT(ctx, t, false)
	dhtB := setupDHT(ctx, t, false)

	defer dhtA.Close()
	defer dhtB.Close()
	defer dhtA.host.Close()
	defer dhtB.host.Close()

	dhtA.Validator.(record.NamespacedValidator)["v"] = blankValidator{}
423
	dhtB.Validator.(record.NamespacedValidator)["v"] = testValidator{}
424 425 426 427

	connect(t, ctx, dhtA, dhtB)

	testSetGet := func(val string, exp string, experr error) {
428 429
		t.Helper()

430 431 432 433
		ctxT, cancel := context.WithTimeout(ctx, time.Second)
		defer cancel()
		err := dhtA.PutValue(ctxT, "/v/hello", []byte(val))
		if err != nil {
434
			t.Error(err)
435 436 437 438 439 440
		}

		ctxT, cancel = context.WithTimeout(ctx, time.Second*2)
		defer cancel()
		valb, err := dhtB.GetValue(ctxT, "/v/hello")
		if err != experr {
Łukasz Magiera's avatar
Łukasz Magiera committed
441
			t.Errorf("Set/Get %v: Expected '%v' error but got '%v'", val, experr, err)
442 443
		} else if err == nil && string(valb) != exp {
			t.Errorf("Expected '%v' got '%s'", exp, string(valb))
444 445 446 447 448 449 450 451 452 453 454 455 456
		}
	}

	// Expired records should not be returned
	testSetGet("expired", "", routing.ErrNotFound)
	// Valid record should be returned
	testSetGet("valid", "valid", nil)
	// Newer record should supersede previous record
	testSetGet("newer", "newer", nil)
	// Attempt to set older record again should be ignored
	testSetGet("valid", "newer", nil)
}

457
func TestInvalidMessageSenderTracking(t *testing.T) {
Steven Allen's avatar
Steven Allen committed
458 459 460
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

461
	dht := setupDHT(ctx, t, false)
Steven Allen's avatar
Steven Allen committed
462 463
	defer dht.Close()

464 465 466 467 468 469 470
	foo := peer.ID("asdasd")
	_, err := dht.messageSenderForPeer(foo)
	if err == nil {
		t.Fatal("that shouldnt have succeeded")
	}

	dht.smlk.Lock()
Steven Allen's avatar
Steven Allen committed
471 472 473 474
	mscnt := len(dht.strmap)
	dht.smlk.Unlock()

	if mscnt > 0 {
475 476 477 478
		t.Fatal("should have no message senders in map")
	}
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
479 480
func TestProvides(t *testing.T) {
	// t.Skip("skipping test to debug another")
Steven Allen's avatar
Steven Allen committed
481 482
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
483

484
	_, _, dhts := setupDHTS(ctx, 4, t)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
485 486
	defer func() {
		for i := 0; i < 4; i++ {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
487
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
488
			defer dhts[i].host.Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
489 490 491
		}
	}()

492 493 494
	connect(t, ctx, dhts[0], dhts[1])
	connect(t, ctx, dhts[1], dhts[2])
	connect(t, ctx, dhts[1], dhts[3])
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
495

496
	for _, k := range testCaseCids {
Matt Joiner's avatar
Matt Joiner committed
497
		logger.Debugf("announcing provider for %s", k)
Jeromy's avatar
Jeromy committed
498
		if err := dhts[3].Provide(ctx, k, true); err != nil {
499 500
			t.Fatal(err)
		}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
501 502
	}

503 504 505 506
	// what is this timeout for? was 60ms before.
	time.Sleep(time.Millisecond * 6)

	n := 0
507
	for _, c := range testCaseCids {
508 509
		n = (n + 1) % 3

Matt Joiner's avatar
Matt Joiner committed
510
		logger.Debugf("getting providers for %s from %d", c, n)
Jeromy's avatar
Jeromy committed
511 512
		ctxT, cancel := context.WithTimeout(ctx, time.Second)
		defer cancel()
513
		provchan := dhts[n].FindProvidersAsync(ctxT, c, 1)
514 515 516 517 518 519 520 521 522 523 524 525 526 527 528

		select {
		case prov := <-provchan:
			if prov.ID == "" {
				t.Fatal("Got back nil provider")
			}
			if prov.ID != dhts[3].self {
				t.Fatal("Got back wrong provider")
			}
		case <-ctxT.Done():
			t.Fatal("Did not get a provider back.")
		}
	}
}

Jeromy's avatar
Jeromy committed
529 530
func TestLocalProvides(t *testing.T) {
	// t.Skip("skipping test to debug another")
Steven Allen's avatar
Steven Allen committed
531 532
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
Jeromy's avatar
Jeromy committed
533 534 535 536 537 538 539 540 541 542 543 544 545 546

	_, _, dhts := setupDHTS(ctx, 4, t)
	defer func() {
		for i := 0; i < 4; i++ {
			dhts[i].Close()
			defer dhts[i].host.Close()
		}
	}()

	connect(t, ctx, dhts[0], dhts[1])
	connect(t, ctx, dhts[1], dhts[2])
	connect(t, ctx, dhts[1], dhts[3])

	for _, k := range testCaseCids {
Matt Joiner's avatar
Matt Joiner committed
547
		logger.Debugf("announcing provider for %s", k)
Jeromy's avatar
Jeromy committed
548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564
		if err := dhts[3].Provide(ctx, k, false); err != nil {
			t.Fatal(err)
		}
	}

	time.Sleep(time.Millisecond * 10)

	for _, c := range testCaseCids {
		for i := 0; i < 3; i++ {
			provs := dhts[i].providers.GetProviders(ctx, c)
			if len(provs) > 0 {
				t.Fatal("shouldnt know this")
			}
		}
	}
}

565 566 567 568 569 570 571 572 573 574
// if minPeers or avgPeers is 0, dont test for it.
func waitForWellFormedTables(t *testing.T, dhts []*IpfsDHT, minPeers, avgPeers int, timeout time.Duration) bool {
	// test "well-formed-ness" (>= minPeers peers in every routing table)

	checkTables := func() bool {
		totalPeers := 0
		for _, dht := range dhts {
			rtlen := dht.routingTable.Size()
			totalPeers += rtlen
			if minPeers > 0 && rtlen < minPeers {
575
				//t.Logf("routing table for %s only has %d peers (should have >%d)", dht.self, rtlen, minPeers)
576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591
				return false
			}
		}
		actualAvgPeers := totalPeers / len(dhts)
		t.Logf("avg rt size: %d", actualAvgPeers)
		if avgPeers > 0 && actualAvgPeers < avgPeers {
			t.Logf("avg rt size: %d < %d", actualAvgPeers, avgPeers)
			return false
		}
		return true
	}

	timeoutA := time.After(timeout)
	for {
		select {
		case <-timeoutA:
Matt Joiner's avatar
Matt Joiner committed
592
			logger.Debugf("did not reach well-formed routing tables by %s", timeout)
593 594 595 596 597 598 599 600 601 602 603
			return false // failed
		case <-time.After(5 * time.Millisecond):
			if checkTables() {
				return true // succeeded
			}
		}
	}
}

func printRoutingTables(dhts []*IpfsDHT) {
	// the routing tables should be full now. let's inspect them.
604
	fmt.Printf("checking routing table of %d\n", len(dhts))
605 606 607 608 609 610 611
	for _, dht := range dhts {
		fmt.Printf("checking routing table of %s\n", dht.self)
		dht.routingTable.Print()
		fmt.Println("")
	}
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
612
func TestBootstrap(t *testing.T) {
613 614 615 616
	if testing.Short() {
		t.SkipNow()
	}

Steven Allen's avatar
Steven Allen committed
617 618
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
619

620
	nDHTs := 30
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
621 622 623 624
	_, _, dhts := setupDHTS(ctx, nDHTs, t)
	defer func() {
		for i := 0; i < nDHTs; i++ {
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
625
			defer dhts[i].host.Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
626 627 628 629 630 631 632 633
		}
	}()

	t.Logf("connecting %d dhts in a ring", nDHTs)
	for i := 0; i < nDHTs; i++ {
		connect(t, ctx, dhts[i], dhts[(i+1)%len(dhts)])
	}

634
	<-time.After(100 * time.Millisecond)
635 636 637 638
	// bootstrap a few times until we get good tables.
	stop := make(chan struct{})
	go func() {
		for {
639
			t.Logf("bootstrapping them so they find each other %d", nDHTs)
Jeromy's avatar
Jeromy committed
640 641
			ctxT, cancel := context.WithTimeout(ctx, 5*time.Second)
			defer cancel()
642 643 644 645 646 647 648 649 650 651 652
			bootstrap(t, ctxT, dhts)

			select {
			case <-time.After(50 * time.Millisecond):
				continue // being explicit
			case <-stop:
				return
			}
		}
	}()

653
	waitForWellFormedTables(t, dhts, 7, 10, 20*time.Second)
654
	close(stop)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
655

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
656 657
	if u.Debug {
		// the routing tables should be full now. let's inspect them.
658 659 660 661 662
		printRoutingTables(dhts)
	}
}

func TestPeriodicBootstrap(t *testing.T) {
663 664 665
	if ci.IsRunning() {
		t.Skip("skipping on CI. highly timing dependent")
	}
666 667 668 669
	if testing.Short() {
		t.SkipNow()
	}

Steven Allen's avatar
Steven Allen committed
670 671
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
672 673 674 675 676 677 678 679 680 681

	nDHTs := 30
	_, _, dhts := setupDHTS(ctx, nDHTs, t)
	defer func() {
		for i := 0; i < nDHTs; i++ {
			dhts[i].Close()
			defer dhts[i].host.Close()
		}
	}()

682 683 684 685
	var cfg BootstrapConfig
	cfg = DefaultBootstrapConfig
	cfg.Queries = 5

686
	t.Logf("dhts are not connected. %d", nDHTs)
687 688 689 690 691 692 693 694 695 696 697
	for _, dht := range dhts {
		rtlen := dht.routingTable.Size()
		if rtlen > 0 {
			t.Errorf("routing table for %s should have 0 peers. has %d", dht.self, rtlen)
		}
	}

	for i := 0; i < nDHTs; i++ {
		connect(t, ctx, dhts[i], dhts[(i+1)%len(dhts)])
	}

698
	t.Logf("DHTs are now connected to 1-2 others. %d", nDHTs)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
699
	for _, dht := range dhts {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
700
		rtlen := dht.routingTable.Size()
701 702
		if rtlen > 2 {
			t.Errorf("routing table for %s should have at most 2 peers. has %d", dht.self, rtlen)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
703
		}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
704
	}
705

706 707 708 709
	if u.Debug {
		printRoutingTables(dhts)
	}

710
	t.Logf("bootstrapping them so they find each other. %d", nDHTs)
Matt Joiner's avatar
Matt Joiner committed
711 712
	for _, dht := range dhts {
		go dht.BootstrapOnce(ctx, cfg)
713
	}
714 715 716

	// this is async, and we dont know when it's finished with one cycle, so keep checking
	// until the routing tables look better, or some long timeout for the failure case.
717
	waitForWellFormedTables(t, dhts, 7, 10, 20*time.Second)
718 719 720

	if u.Debug {
		printRoutingTables(dhts)
721
	}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
722 723
}

724 725
func TestProvidesMany(t *testing.T) {
	t.Skip("this test doesn't work")
Steven Allen's avatar
Steven Allen committed
726 727
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
728 729 730 731 732 733

	nDHTs := 40
	_, _, dhts := setupDHTS(ctx, nDHTs, t)
	defer func() {
		for i := 0; i < nDHTs; i++ {
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
734
			defer dhts[i].host.Close()
735 736 737 738 739 740 741 742
		}
	}()

	t.Logf("connecting %d dhts in a ring", nDHTs)
	for i := 0; i < nDHTs; i++ {
		connect(t, ctx, dhts[i], dhts[(i+1)%len(dhts)])
	}

743
	<-time.After(100 * time.Millisecond)
744
	t.Logf("bootstrapping them so they find each other. %d", nDHTs)
Jeromy's avatar
Jeromy committed
745 746
	ctxT, cancel := context.WithTimeout(ctx, 20*time.Second)
	defer cancel()
747 748
	bootstrap(t, ctxT, dhts)

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
749 750 751 752 753 754 755 756
	if u.Debug {
		// the routing tables should be full now. let's inspect them.
		t.Logf("checking routing table of %d", nDHTs)
		for _, dht := range dhts {
			fmt.Printf("checking routing table of %s\n", dht.self)
			dht.routingTable.Print()
			fmt.Println("")
		}
757
	}
758

759
	providers := make(map[string]peer.ID)
760

761
	d := 0
762
	for _, c := range testCaseCids {
763 764
		d = (d + 1) % len(dhts)
		dht := dhts[d]
765
		providers[c.KeyString()] = dht.self
766

767
		t.Logf("announcing provider for %s", c)
Jeromy's avatar
Jeromy committed
768
		if err := dht.Provide(ctx, c, true); err != nil {
769 770
			t.Fatal(err)
		}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
771 772
	}

773 774
	// what is this timeout for? was 60ms before.
	time.Sleep(time.Millisecond * 6)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
775

776 777
	errchan := make(chan error)

Jeromy's avatar
Jeromy committed
778 779
	ctxT, cancel = context.WithTimeout(ctx, 5*time.Second)
	defer cancel()
780 781

	var wg sync.WaitGroup
782
	getProvider := func(dht *IpfsDHT, k cid.Cid) {
783
		defer wg.Done()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
784

785
		expected := providers[k.KeyString()]
786

787 788 789
		provchan := dht.FindProvidersAsync(ctxT, k, 1)
		select {
		case prov := <-provchan:
790 791
			actual := prov.ID
			if actual == "" {
792
				errchan <- fmt.Errorf("Got back nil provider (%s at %s)", k, dht.self)
793 794 795
			} else if actual != expected {
				errchan <- fmt.Errorf("Got back wrong provider (%s != %s) (%s at %s)",
					expected, actual, k, dht.self)
796 797 798
			}
		case <-ctxT.Done():
			errchan <- fmt.Errorf("Did not get a provider back (%s at %s)", k, dht.self)
Jeromy's avatar
Jeromy committed
799
		}
800 801
	}

802
	for _, c := range testCaseCids {
803 804
		// everyone should be able to find it...
		for _, dht := range dhts {
Matt Joiner's avatar
Matt Joiner committed
805
			logger.Debugf("getting providers for %s at %s", c, dht.self)
806
			wg.Add(1)
807
			go getProvider(dht, c)
808
		}
809 810 811 812 813 814 815 816 817 818
	}

	// we need this because of printing errors
	go func() {
		wg.Wait()
		close(errchan)
	}()

	for err := range errchan {
		t.Error(err)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
819 820 821
	}
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
822
func TestProvidesAsync(t *testing.T) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
823
	// t.Skip("skipping test to debug another")
824 825 826
	if testing.Short() {
		t.SkipNow()
	}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
827

Steven Allen's avatar
Steven Allen committed
828 829
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
830

831
	_, _, dhts := setupDHTS(ctx, 4, t)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
832 833
	defer func() {
		for i := 0; i < 4; i++ {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
834
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
835
			defer dhts[i].host.Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
836 837 838
		}
	}()

839 840 841
	connect(t, ctx, dhts[0], dhts[1])
	connect(t, ctx, dhts[1], dhts[2])
	connect(t, ctx, dhts[1], dhts[3])
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
842

Jeromy's avatar
Jeromy committed
843
	err := dhts[3].Provide(ctx, testCaseCids[0], true)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
844 845 846 847 848 849
	if err != nil {
		t.Fatal(err)
	}

	time.Sleep(time.Millisecond * 60)

Jeromy's avatar
Jeromy committed
850 851
	ctxT, cancel := context.WithTimeout(ctx, time.Millisecond*300)
	defer cancel()
852
	provs := dhts[0].FindProvidersAsync(ctxT, testCaseCids[0], 5)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
853
	select {
Jeromy's avatar
Jeromy committed
854 855 856 857
	case p, ok := <-provs:
		if !ok {
			t.Fatal("Provider channel was closed...")
		}
858
		if p.ID == "" {
Jeromy's avatar
Jeromy committed
859 860
			t.Fatal("Got back nil provider!")
		}
861
		if p.ID != dhts[3].self {
862
			t.Fatalf("got a provider, but not the right one. %s", p)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
863
		}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
864
	case <-ctxT.Done():
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
865 866 867 868
		t.Fatal("Didnt get back providers")
	}
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
869
func TestLayeredGet(t *testing.T) {
870 871
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
872

873
	_, _, dhts := setupDHTS(ctx, 4, t)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
874 875
	defer func() {
		for i := 0; i < 4; i++ {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
876
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
877
			defer dhts[i].host.Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
878 879 880
		}
	}()

881 882
	connect(t, ctx, dhts[0], dhts[1])
	connect(t, ctx, dhts[1], dhts[2])
883
	connect(t, ctx, dhts[2], dhts[3])
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
884

885
	err := dhts[3].PutValue(ctx, "/v/hello", []byte("world"))
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
886 887 888 889
	if err != nil {
		t.Fatal(err)
	}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
890
	time.Sleep(time.Millisecond * 6)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
891

Jeromy's avatar
Jeromy committed
892 893
	ctxT, cancel := context.WithTimeout(ctx, time.Second)
	defer cancel()
894 895 896
	val, err := dhts[0].GetValue(ctxT, "/v/hello")
	if err != nil {
		t.Fatal(err)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
897
	}
898 899 900

	if string(val) != "world" {
		t.Error("got wrong value")
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
901 902 903 904
	}
}

func TestFindPeer(t *testing.T) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
905
	// t.Skip("skipping test to debug another")
906 907 908
	if testing.Short() {
		t.SkipNow()
	}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
909

Steven Allen's avatar
Steven Allen committed
910 911
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
912

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
913
	_, peers, dhts := setupDHTS(ctx, 4, t)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
914 915
	defer func() {
		for i := 0; i < 4; i++ {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
916
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
917
			dhts[i].host.Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
918 919 920
		}
	}()

921 922 923
	connect(t, ctx, dhts[0], dhts[1])
	connect(t, ctx, dhts[1], dhts[2])
	connect(t, ctx, dhts[1], dhts[3])
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
924

Jeromy's avatar
Jeromy committed
925 926
	ctxT, cancel := context.WithTimeout(ctx, time.Second)
	defer cancel()
927
	p, err := dhts[0].FindPeer(ctxT, peers[2])
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
928 929 930 931
	if err != nil {
		t.Fatal(err)
	}

932
	if p.ID == "" {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
933 934 935
		t.Fatal("Failed to find peer.")
	}

936
	if p.ID != peers[2] {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
937 938 939
		t.Fatal("Didnt find expected peer.")
	}
}
940

941
func TestFindPeersConnectedToPeer(t *testing.T) {
942 943
	t.Skip("not quite correct (see note)")

944 945 946 947
	if testing.Short() {
		t.SkipNow()
	}

Steven Allen's avatar
Steven Allen committed
948 949
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
950 951 952 953 954

	_, peers, dhts := setupDHTS(ctx, 4, t)
	defer func() {
		for i := 0; i < 4; i++ {
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
955
			dhts[i].host.Close()
956 957 958 959 960
		}
	}()

	// topology:
	// 0-1, 1-2, 1-3, 2-3
961 962 963 964
	connect(t, ctx, dhts[0], dhts[1])
	connect(t, ctx, dhts[1], dhts[2])
	connect(t, ctx, dhts[1], dhts[3])
	connect(t, ctx, dhts[2], dhts[3])
965 966 967 968 969 970

	// fmt.Println("0 is", peers[0])
	// fmt.Println("1 is", peers[1])
	// fmt.Println("2 is", peers[2])
	// fmt.Println("3 is", peers[3])

Jeromy's avatar
Jeromy committed
971 972
	ctxT, cancel := context.WithTimeout(ctx, time.Second)
	defer cancel()
973
	pchan, err := dhts[0].FindPeersConnectedToPeer(ctxT, peers[2])
974 975 976 977
	if err != nil {
		t.Fatal(err)
	}

978
	// shouldFind := []peer.ID{peers[1], peers[3]}
Jeromy's avatar
Jeromy committed
979
	var found []*pstore.PeerInfo
980 981 982 983 984 985 986 987 988 989
	for nextp := range pchan {
		found = append(found, nextp)
	}

	// fmt.Printf("querying 0 (%s) FindPeersConnectedToPeer 2 (%s)\n", peers[0], peers[2])
	// fmt.Println("should find 1, 3", shouldFind)
	// fmt.Println("found", found)

	// testPeerListsMatch(t, shouldFind, found)

Matt Joiner's avatar
Matt Joiner committed
990
	logger.Warning("TestFindPeersConnectedToPeer is not quite correct")
991 992 993 994 995
	if len(found) == 0 {
		t.Fatal("didn't find any peers.")
	}
}

996
func testPeerListsMatch(t *testing.T, p1, p2 []peer.ID) {
997 998 999 1000 1001 1002 1003 1004 1005

	if len(p1) != len(p2) {
		t.Fatal("did not find as many peers as should have", p1, p2)
	}

	ids1 := make([]string, len(p1))
	ids2 := make([]string, len(p2))

	for i, p := range p1 {
1006
		ids1[i] = string(p)
1007 1008 1009
	}

	for i, p := range p2 {
1010
		ids2[i] = string(p)
1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022
	}

	sort.Sort(sort.StringSlice(ids1))
	sort.Sort(sort.StringSlice(ids2))

	for i := range ids1 {
		if ids1[i] != ids2[i] {
			t.Fatal("Didnt find expected peer", ids1[i], ids2)
		}
	}
}

1023
func TestConnectCollision(t *testing.T) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1024
	// t.Skip("skipping test to debug another")
1025 1026 1027
	if testing.Short() {
		t.SkipNow()
	}
1028 1029 1030
	if travisci.IsRunning() {
		t.Skip("Skipping on Travis-CI.")
	}
1031

1032
	runTimes := 10
1033

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1034
	for rtime := 0; rtime < runTimes; rtime++ {
Matt Joiner's avatar
Matt Joiner committed
1035
		logger.Info("Running Time: ", rtime)
1036

Steven Allen's avatar
Steven Allen committed
1037
		ctx, cancel := context.WithCancel(context.Background())
1038

1039 1040
		dhtA := setupDHT(ctx, t, false)
		dhtB := setupDHT(ctx, t, false)
1041

1042 1043
		addrA := dhtA.peerstore.Addrs(dhtA.self)[0]
		addrB := dhtB.peerstore.Addrs(dhtB.self)[0]
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1044

1045 1046
		peerA := dhtA.self
		peerB := dhtB.self
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1047

1048
		errs := make(chan error)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1049
		go func() {
Jeromy's avatar
Jeromy committed
1050 1051
			dhtA.peerstore.AddAddr(peerB, addrB, pstore.TempAddrTTL)
			pi := pstore.PeerInfo{ID: peerB}
Jeromy's avatar
Jeromy committed
1052
			err := dhtA.host.Connect(ctx, pi)
1053
			errs <- err
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1054 1055
		}()
		go func() {
Jeromy's avatar
Jeromy committed
1056 1057
			dhtB.peerstore.AddAddr(peerA, addrA, pstore.TempAddrTTL)
			pi := pstore.PeerInfo{ID: peerA}
Jeromy's avatar
Jeromy committed
1058
			err := dhtB.host.Connect(ctx, pi)
1059
			errs <- err
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1060 1061
		}()

1062
		timeout := time.After(5 * time.Second)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1063
		select {
1064 1065 1066 1067
		case e := <-errs:
			if e != nil {
				t.Fatal(e)
			}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1068 1069 1070 1071
		case <-timeout:
			t.Fatal("Timeout received!")
		}
		select {
1072 1073 1074 1075
		case e := <-errs:
			if e != nil {
				t.Fatal(e)
			}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1076 1077 1078 1079
		case <-timeout:
			t.Fatal("Timeout received!")
		}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1080 1081
		dhtA.Close()
		dhtB.Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1082 1083
		dhtA.host.Close()
		dhtB.host.Close()
Steven Allen's avatar
Steven Allen committed
1084
		cancel()
Jeromy's avatar
Jeromy committed
1085
	}
1086
}
1087 1088 1089 1090 1091

func TestBadProtoMessages(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

1092
	d := setupDHT(ctx, t, false)
1093 1094 1095 1096 1097 1098

	nilrec := new(pb.Message)
	if _, err := d.handlePutValue(ctx, "testpeer", nilrec); err == nil {
		t.Fatal("should have errored on nil record")
	}
}
1099 1100 1101 1102 1103 1104 1105 1106 1107 1108

func TestClientModeConnect(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	a := setupDHT(ctx, t, false)
	b := setupDHT(ctx, t, true)

	connectNoSync(t, ctx, a, b)

1109
	c := testCaseCids[0]
1110
	p := peer.ID("TestPeer")
1111 1112
	a.providers.AddProvider(ctx, c, p)
	time.Sleep(time.Millisecond * 5) // just in case...
1113

1114
	provs, err := b.FindProviders(ctx, c)
1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125
	if err != nil {
		t.Fatal(err)
	}

	if len(provs) == 0 {
		t.Fatal("Expected to get a provider back")
	}

	if provs[0].ID != p {
		t.Fatal("expected it to be our test peer")
	}
Steven Allen's avatar
Steven Allen committed
1126 1127 1128 1129 1130 1131 1132 1133 1134
	if a.routingTable.Find(b.self) != "" {
		t.Fatal("DHT clients should not be added to routing tables")
	}
	if b.routingTable.Find(a.self) == "" {
		t.Fatal("DHT server should have been added to the dht client's routing table")
	}
}

func TestClientModeFindPeer(t *testing.T) {
1135
	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
Steven Allen's avatar
Steven Allen committed
1136 1137 1138 1139 1140 1141
	defer cancel()

	a := setupDHT(ctx, t, false)
	b := setupDHT(ctx, t, true)
	c := setupDHT(ctx, t, true)

1142 1143
	connectNoSync(t, ctx, b, a)
	connectNoSync(t, ctx, c, a)
Steven Allen's avatar
Steven Allen committed
1144 1145

	// Can't use `connect` because b and c are only clients.
1146 1147
	wait(t, ctx, b, a)
	wait(t, ctx, c, a)
Steven Allen's avatar
Steven Allen committed
1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160

	pi, err := c.FindPeer(ctx, b.self)
	if err != nil {
		t.Fatal(err)
	}
	if len(pi.Addrs) == 0 {
		t.Fatal("should have found addresses for node b")
	}

	err = c.host.Connect(ctx, pi)
	if err != nil {
		t.Fatal(err)
	}
1161
}
1162

Matt Joiner's avatar
Matt Joiner committed
1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174
func minInt(a, b int) int {
	if a < b {
		return a
	} else {
		return b
	}
}

func TestFindPeerQueryMinimal(t *testing.T) {
	testFindPeerQuery(t, 2, 22, 11)
}

1175
func TestFindPeerQuery(t *testing.T) {
Matt Joiner's avatar
Matt Joiner committed
1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189
	if testing.Short() {
		t.Skip("skipping test in short mode")
	}
	if curFileLimit() < 1024 {
		t.Skip("insufficient file descriptors available")
	}
	testFindPeerQuery(t, 20, 80, 16)
}

func testFindPeerQuery(t *testing.T,
	bootstrappers, // Number of nodes connected to the querying node
	leafs, // Number of nodes that might be connected to from the bootstrappers
	bootstrapperLeafConns int, // Number of connections each bootstrapper has to the leaf nodes
) {
1190 1191 1192
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

Matt Joiner's avatar
Matt Joiner committed
1193
	_, allpeers, dhts := setupDHTS(ctx, 1+bootstrappers+leafs, t)
1194
	defer func() {
Matt Joiner's avatar
Matt Joiner committed
1195 1196 1197
		for _, d := range dhts {
			d.Close()
			d.host.Close()
1198 1199 1200
		}
	}()

Jeromy's avatar
Jeromy committed
1201
	mrand := rand.New(rand.NewSource(42))
1202 1203
	guy := dhts[0]
	others := dhts[1:]
Matt Joiner's avatar
Matt Joiner committed
1204 1205 1206 1207
	for i := 0; i < bootstrappers; i++ {
		for j := 0; j < bootstrapperLeafConns; j++ {
			v := mrand.Intn(leafs)
			connect(t, ctx, others[i], others[bootstrappers+v])
1208 1209 1210
		}
	}

Matt Joiner's avatar
Matt Joiner committed
1211
	for i := 0; i < bootstrappers; i++ {
1212 1213 1214
		connect(t, ctx, guy, others[i])
	}

Matt Joiner's avatar
Matt Joiner committed
1215 1216 1217 1218 1219 1220 1221 1222 1223 1224
	var reachableIds []peer.ID
	for i, d := range dhts {
		lp := len(d.host.Network().Peers())
		//t.Log(i, lp)
		if i != 0 && lp > 0 {
			reachableIds = append(reachableIds, allpeers[i])
		}
	}
	t.Logf("%d reachable ids", len(reachableIds))

1225 1226 1227
	val := "foobar"
	rtval := kb.ConvertKey(val)

Jeromy's avatar
Jeromy committed
1228
	rtablePeers := guy.routingTable.NearestPeers(rtval, AlphaValue)
Matt Joiner's avatar
Matt Joiner committed
1229
	assert.Len(t, rtablePeers, minInt(bootstrappers, AlphaValue))
1230

Matt Joiner's avatar
Matt Joiner committed
1231
	assert.Len(t, guy.host.Network().Peers(), bootstrappers)
1232 1233

	out, err := guy.GetClosestPeers(ctx, val)
Matt Joiner's avatar
Matt Joiner committed
1234
	require.NoError(t, err)
1235 1236 1237 1238 1239 1240

	var outpeers []peer.ID
	for p := range out {
		outpeers = append(outpeers, p)
	}

Jeromy's avatar
Jeromy committed
1241
	sort.Sort(peer.IDSlice(outpeers))
Steven Allen's avatar
Steven Allen committed
1242

Matt Joiner's avatar
Matt Joiner committed
1243 1244
	exp := kb.SortClosestPeers(reachableIds, rtval)[:minInt(KValue, len(reachableIds))]
	t.Logf("got %d peers", len(outpeers))
1245
	got := kb.SortClosestPeers(outpeers, rtval)
Jeromy's avatar
Jeromy committed
1246

Matt Joiner's avatar
Matt Joiner committed
1247
	assert.EqualValues(t, exp, got)
1248 1249
}

1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281
func TestFindClosestPeers(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	nDHTs := 30
	_, _, dhts := setupDHTS(ctx, nDHTs, t)
	defer func() {
		for i := 0; i < nDHTs; i++ {
			dhts[i].Close()
			defer dhts[i].host.Close()
		}
	}()

	t.Logf("connecting %d dhts in a ring", nDHTs)
	for i := 0; i < nDHTs; i++ {
		connect(t, ctx, dhts[i], dhts[(i+1)%len(dhts)])
	}

	peers, err := dhts[1].GetClosestPeers(ctx, "foo")
	if err != nil {
		t.Fatal(err)
	}

	var out []peer.ID
	for p := range peers {
		out = append(out, p)
	}

	if len(out) != KValue {
		t.Fatalf("got wrong number of peers (got %d, expected %d)", len(out), KValue)
	}
}
1282 1283

func TestGetSetPluggedProtocol(t *testing.T) {
1284 1285 1286
	t.Run("PutValue/GetValue - same protocol", func(t *testing.T) {
		ctx, cancel := context.WithCancel(context.Background())
		defer cancel()
1287

1288 1289 1290 1291 1292
		os := []opts.Option{
			opts.Protocols("/esh/dht"),
			opts.Client(false),
			opts.NamespacedValidator("v", blankValidator{}),
		}
1293

Steven Allen's avatar
Steven Allen committed
1294
		dhtA, err := New(ctx, bhost.New(swarmt.GenSwarm(t, ctx, swarmt.OptDisableReuseport)), os...)
1295 1296 1297
		if err != nil {
			t.Fatal(err)
		}
1298

Steven Allen's avatar
Steven Allen committed
1299
		dhtB, err := New(ctx, bhost.New(swarmt.GenSwarm(t, ctx, swarmt.OptDisableReuseport)), os...)
1300 1301 1302
		if err != nil {
			t.Fatal(err)
		}
1303

1304
		connect(t, ctx, dhtA, dhtB)
1305

1306
		ctxT, cancel := context.WithTimeout(ctx, time.Second)
1307
		defer cancel()
1308 1309 1310
		if err := dhtA.PutValue(ctxT, "/v/cat", []byte("meow")); err != nil {
			t.Fatal(err)
		}
1311

1312 1313 1314 1315
		value, err := dhtB.GetValue(ctxT, "/v/cat")
		if err != nil {
			t.Fatal(err)
		}
1316

1317 1318 1319 1320 1321
		if string(value) != "meow" {
			t.Fatalf("Expected 'meow' got '%s'", string(value))
		}
	})

1322 1323
	t.Run("DHT routing table for peer A won't contain B if A and B don't use same protocol", func(t *testing.T) {
		ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
1324 1325
		defer cancel()

Steven Allen's avatar
Steven Allen committed
1326
		dhtA, err := New(ctx, bhost.New(swarmt.GenSwarm(t, ctx, swarmt.OptDisableReuseport)), []opts.Option{
1327 1328 1329
			opts.Protocols("/esh/dht"),
			opts.Client(false),
			opts.NamespacedValidator("v", blankValidator{}),
1330
		}...)
1331 1332 1333 1334
		if err != nil {
			t.Fatal(err)
		}

Steven Allen's avatar
Steven Allen committed
1335
		dhtB, err := New(ctx, bhost.New(swarmt.GenSwarm(t, ctx, swarmt.OptDisableReuseport)), []opts.Option{
1336 1337 1338
			opts.Protocols("/lsr/dht"),
			opts.Client(false),
			opts.NamespacedValidator("v", blankValidator{}),
1339
		}...)
1340 1341 1342 1343
		if err != nil {
			t.Fatal(err)
		}

1344
		connectNoSync(t, ctx, dhtA, dhtB)
1345

1346 1347 1348 1349 1350 1351 1352
		// We don't expect connection notifications for A to reach B (or vice-versa), given
		// that they've been configured with different protocols - but we'll give them a
		// chance, anyhow.
		time.Sleep(time.Second * 2)

		err = dhtA.PutValue(ctx, "/v/cat", []byte("meow"))
		if err == nil || !strings.Contains(err.Error(), "failed to find any peer in table") {
1353
			t.Fatalf("put should not have been able to find any peers in routing table, err:'%v'", err)
1354 1355
		}

1356 1357
		_, err = dhtB.GetValue(ctx, "/v/cat")
		if err == nil || !strings.Contains(err.Error(), "failed to find any peer in table") {
1358
			t.Fatalf("get should not have been able to find any peers in routing table, err:'%v'", err)
1359
		}
1360
	})
1361
}